Missing Return Statement Error

Hi All

I have problem with below method - I understand it means that Sting is not being retuned - but I don't understand why cause I clearly stated in code that string should be returned. Please help:

Code:

---

  /**
    * If the argument is between 1 and 3 inclusive,
    * sets the value of its playingMode instance variable to the value of the int argument,
    * otherwise returns the string: "Playing mode unchanged".
    */
  public String selectProgram(int aValue)
  {
      if (aValue >= 1 && aValue <= 3)
      {
          this.setPlayingMode(aValue);
          if (this.getPlayingMode() == 1)
          {
              return "Repeat off";
            }
            if (this.getPlayingMode() == 2)
            {
                return "Repeat track";
            }
            if (this.getPlayingMode() == 3)
            {
                return "Repeat all";
            }
        }
        else
        {
            return "Playing mode unchanged";
        }
    }  ---- ERROR IS HERE -- It highlights this bracket.

---

The if statements are set up so that there is a possibility of the method finishing without returning everything. Go through your logic and you'll see.

I really don't understand

Method should return one String message and its set to do that using if - else statement. Should I use while or for instead?

Again, it's all in your logic. What if aValue is >= 1 and <=3 but playing mode is not 1, 2, or 3? Even if this is not possible, the compiler doesn't know. You should consider having a default return value or throw an exception.

i thought that if 'if' condition is not true than below statement will return String anyway so there is no need for default condition:

Code:

---

        else
        {
            return "Playing mode unchanged";
        }

---

would changing this.getPlayingMode() for aValue fix the problem?

change
if (this.getPlayingMode() == 3)
{
return "Repeat all";
}
to
else{
return "Repeat all";
}

it will solve the problem

Thanks!
That did fixed my problem, but I have exactly the same error (missing return statement) with another method:

Code:

---

    /**
    * It increments the value of its trackNumber instance variable by 1
    * but only if its current value is less than the maximum value of 20.
    * Returns the value of the current track number.
    */
    public int up()
    {
    if ((this.trackNumber >= 1) && (this.trackNumber < 20))
    {
        this.setTrackNumber(trackNumber++);
        this.getTrackNumber();
    }
    }

---

Like Fubarable said, your inner if clause gives you hard time.

Run this simple code.
Use debugger.
Use values 21,22,23 to see what is going on.
Remove else in inner if and uncomment last return and it will clear up things for you.

Code:

---

public String getInenerIfReponse(int a){
               
                if (a >= 22)
                {       
                        if (a == 23) //inner if
                                return        "a = 23";
                        else return "a >= 22 but not 23"; //THIS IS CONDITION YOU MISSED; IF YOU DON'T WRITE THIS LINE, YOU MUST UNCOMMENT : return "inner if does not fulfill condition
                }
               
                else
                return "a < 22";
               
                // if inner if (a==23) is false, this line will be called to return value
                //return "inner if does not fulfill condition";
        }

---

got it now?

Quote:

---

Originally Posted by darkblue24

Thanks!
That did fixed my problem, but I have exactly the same error (missing return statement) with another method:

Code:

---

    /**
    * It increments the value of its trackNumber instance variable by 1
    * but only if its current value is less than the maximum value of 20.
    * Returns the value of the current track number.
    */
    public int up()
    {
    if ((this.trackNumber >= 1) && (this.trackNumber < 20))
    {
        this.setTrackNumber(trackNumber++);
        this.getTrackNumber();
    }
    }

---

---

Acctually, the problem here is, that there is no return satatement. If all you want to do is increase an inner value, you could just make it's return type void (so, no return statement is necessary), or maybe boolean, just so you know, when trackNumber goes to 20 and won't increment anymore.

Code:

---

public boolean up()
    {
    if ((this.trackNumber >= 1) && (this.trackNumber < 20))
    {
        this.setTrackNumber(trackNumber++);
        this.getTrackNumber();
        return true;
    }
    else
    {
      return false;
    }
    }

---

hi Guys

This is the instructions about how up() method should be constructed:

When an instance of CDPlayer receives an up() message it should increment
the value of its trackNumber instance variable by 1 but only if its current value is
less than the maximum value of 20. The method should then return the value of
the current track number (whether or not trackNumber has been changed). Write
the up() method for the CDPlayer class.

trackNumber instance variable is declared as integer so I think up() method should be returning int (not boolean):

how can I alter it below code to get rid of 'missing return statement' error ???

Code:

---

  /**
    * If the argument is between 1 and 3 inclusive,
    * sets the value of its playingMode instance variable to the value of the int argument,
    * otherwise returns the string: "Playing mode unchanged".
    */
  public String selectProgram(int aValue)
  {
      if (aValue >= 1 && aValue <= 3)
      {
          this.setPlayingMode(aValue);
          if (this.getPlayingMode() == 1)
          {
              return "Repeat off";
            }
            if (this.getPlayingMode() == 2)
            {
                return "Repeat track";
            }
            if (this.getPlayingMode() == 3)
            {
                return "Repeat all";
            }
        }
        else
        {
            return "Playing mode unchanged";
        }
    }  ---- ERROR IS HERE -- It highlights this bracket.

---

I'm confused as the answer has already been given, and several times too. Are you looking for someone to re-write your code for you?

Your code does not match your instructions, as I see it. It seems to me you haven't even tried to do the work.

I just simply could not understood why the error says that int is not returned while it was - some one could explained that to me... I have fixed that method my self:

Code:

---

    /**
    * It increments the value of its trackNumber instance variable by 1
    * but only if its current value is less than the maximum value of 20.
    * Returns the value of the current track number.
    */
    public int up()
    {
    if ((this.trackNumber >= 1) && (this.trackNumber < 20))
    {
        this.setTrackNumber(trackNumber++);
        return this.trackNumber;
    }
    else
    {
        return this.trackNumber;
    }
    }

---

I found Danderdode's answer rude and pointless. It's this user first post and I hope last on this forum.

To all the others - Thanks for help guys.

My intent was not to be rude to anyone. I was stating that I didn't understand what the issue was since the description of the question did not match the code, therefore I assumed you hadn't even tried to do the work since it sounds like a class room question. For you to respond like you did is childish.