BubbleSorting Problem: invalid method declaration

So im so close to finishing this bubblesorting prog. all i have is one error.

Take a look see if you can help

All help is appreciated:)

Code:

---

public class BubbleSort
{
 class ArrayBub
{
  private long a[];
  private int nElems;
}

public ArrayBub(int max)
{
  a=new long[max];
  nElems=0;
}
public void insert(long value)
{
        a[nElems]=value;
        nElems++;
}
public void display()
{
        for(int j=0;j<nElems;j++)
        System.out.print(a[j]+" ");
        Util.skip(1);
}
public void bubbleSort()
{
  int out,in;
  for(out=nElems-1; out>1; out--)
  for(in=0; in<out; in++)
  if( a[in] > a[in+1] )
  swap(in, in+1);
}
public void swap(int one,int two)
{
        long temp=a[one];
        a[one]=a[two];
        a[two]=temp;
}
class BubbleSortApp
{
        public static void main(String[] args)
        {
                int maxSize=100;
                ArrayBub arr;
                arr=new ArrayBub(maxSize);
                arr.insert(77);
                arr.insert(99);
        arr.insert(44);
        arr.insert(55);
        arr.insert(22);
        arr.insert(88);
        arr.insert(11);
        arr.insert(00);
        arr.insert(66);
        arr.insert(33);
        arr.display();
        arr.bubbleSort();
        arr.display();

               
        }
}
}

---

And my error is:

Code:

---

C:\BubbleSort.java:10: invalid method declaration; return type required
public ArrayBub(int max)

---

Quote:

---

Originally Posted by SwEeTAcTioN

Code:

---

public class BubbleSort
{
 class ArrayBub
{
  private long a[];
  private int nElems;
}

public ArrayBub(int max)
{
  a=new long[max];
  nElems=0;
}
...

---

And my error is:

Code:

---

C:\BubbleSort.java:10: invalid method declaration; return type required
public ArrayBub(int max)

---

---

Right, your ArrayBub method is not a constructor. It's located in the BubbleSort class; it's not in ArrayBub, should it be??

im not sure really???:(:(:confused::confused:

how would you do that

Move the ArrayBub constructor inside of the AraryBub class - literally, physically move the code, and it will work fine.

Edit:
OK, after reviewing your code, it looks like your Class name should be named ArrayBub, instead of BubbleSort, since ALL the methods are part of the ArrayBub class, and not in BubbleSort. Is there a reason you used a nested class?

so i tryed that and no success:(

You should be using only one class for this. It seems you called it ArrayBub. All the methods you have should be in this one class.

Your other classes BubbleSort and BubbleSortApp do nothing but introduce bugs into your program. Put ALL the methods in the same class, ArrayBub, and it works fine.

Quote:

---

Originally Posted by CodesAway

Is there a reason you used a nested class?

---

Good question.

@OP Saying you had "no success" conveys very little information about what your code now is, or what the effect of compiling it was.