Code executes after thread

[bubbless]

Hi all,

I have 2 threads: the main thread and a download thread, who downloads a page from the internet.

Code:

		String numberOfPages = JOptionPane.showInputDialog("Aantal pagina's:");
		if(numberOfPages != null) {
			if(!numberOfPages.equals("0")) {
				model.getProgressBar(type).setIndeterminate(true);
				model.getProgressBar(type).setStringPainted(true);
				model.getProgressBar(type).setString("Pagina's downloaden...");
				if(type == 1) {
					for(int i = 1; i <= Integer.valueOf(numberOfPages); i++) {
						DownloadPage downloadPage = new DownloadPage(deTijd, i, deTijd.reverseLastPaper(deTijd.getLastPaper()));
						Thread downloadPageThread = new Thread(downloadPage);
						downloadPageThread.start();
						model.getProgressBar(type).setString("Pagina's downloaden "+i+"/"+numberOfPages);
						try {
							downloadPageThread.join();
						} catch (InterruptedException e) {
							e.printStackTrace();
						}
					}

The problem is that this code:

				model.getProgressBar(type).setIndeterminate(true);
				model.getProgressBar(type).setStringPainted(true);
				model.getProgressBar(type).setString("Pagina's downloaden...");

Executes after the for loop has finished.
I really can't find the problem.

Thanks in advance.
Glenn

[Fubarable]

Are you sure that the downloads are being done off of the Swing EDT (event dispatch thread) and that the Swing calls are done on the EDT?

If not, please read the Sun tutorial "Concurrency in Swing".

[collin389]

I had a similar problem, you have to make a swingworker and run that in order to update your swing in this case.

[dinosoep]

debug your code in an ide does it really executes then?
i think you should repaint your form to see it visibly.

[bubbless]

The download happens in a complete seperate thread, wich has nothing to do with the main thread, where I update the gui.
As you see, the progressbar needs to be set to indeterminate, the pages need to be downloaded, and the progressbar needs to be set to complete.
But the pages download first.

It executes fine, execpt for the progressbar who updates after the other thread has finished.
Also, repainting the progressbar didn't do anything.

Edit.
Fubarable, to answer your question, SwingUtilities.isEventDispatchThread() returned true in the main thread and false in the download thread.

Another edit.
I think the problem lies in the join method.
The EDT joins the download thread and so it freezes until that thread has finished.
Is there any other way to see if the thread has finished?

[Fubarable]

Don't use join!

If you use a SwingWorker, you'll know that the thread is done as the done() method will be called. You could do a similar thing yourself but make it event-driven (such as with the Observer Model). Don't do join otherwise you lose the benefits of threading.