For Loop

[YiBoog]

Greetings...I am working on drawing a d<>amond using my for loops. I have the top portion of my diamond working correctly but the bottom doesn't want to follow orders. The bottom triangle spaces do not match right. I was wondering if someone could take a look at where the error is coming from in the bottom triangle. I know there are more ways to do this and would also appreciate if you have other suggestions on to shorten and make this code look more elegant. Thanks!!

public class Diamond
{
	static void diamondOfAsterisks(int len)
	{
		for (int i = 1; i <= len; i++)
		{			
			// print spaces for top
			for (int j = 1; j <= len - i; j++)
			{
				System.out.print(" ");
			}
			
			// print asterisks
			for (int j = 1; j <= 2 * i - 1; j++)
			{
				System.out.print("*");
			}
			System.out.println();
		}
	
		// for each line of the bottom
		for (int i = len - 1; i >= 1; i--)
		{			
			// print spaces for bottom
			for (int j = len - 1; j <= len - i + 1; j++)
			{
				System.out.print(" ");
			}
			
			// print asterisks
			for (int j = 1; j <= 2 * i - 1; j++)
			{
				System.out.print("*");
			}
			System.out.println();
		}
	}

This is being called from the main()...

[JosAH]

Your spaces for the top part:

			// print spaces for top
			for (int j = 1; j <= len - i; j++)

Your spaces for the bottom part:

			// print spaces for bottom
			for (int j = len - 1; j <= len - i + 1; j++)

Why don't you use equal loops for both parts? Your loop for the bottom part is incorrect (look closely).

kind regards,

Jos

[YiBoog]

Ok, so I made the change, however, the last star (the single one at the bottom) does not print. Is it suppose to? It leaves only 3 asterisks at the end and I thought it should have printed the last single one??? Any thoughts on this?? :confused:

Respectfully,

Boog

public class Diamond
{
	static void diamondOfAsterisks(int len)
	{
		for (int i = 1; i <= len; i++)
		{			
			// print spaces for top
			for (int j = 1; j <= len - i; j++)
			{
				System.out.print(" ");
			}
			
			// print asterisks
			for (int j = 1; j <= 2 * i - 1; j++)
			{
				System.out.print("*");
			}
			System.out.println();
		}
	
		// for each line of the bottom
		for (int i = len - 1; i >= 1; i--)
		{			
			// print spaces for bottom
			for (int j = 1; j <= len - i; j++)
			{
				System.out.print(" ");
			}
			
			// print asterisks
			for (int j = 1; j <= 2 * i - 1; j++)
			{
				System.out.print("*");
			}
			System.out.println();
		}
	}

[JosAH]

Ok, so I made the change, however, the last star (the single one at the bottom) does not print. Is it suppose to? It leaves only 3 asterisks at the end and I thought it should have printed the last single one??? Any thoughts on this?? :confused:

			// print asterisks
			for (int j = 1; j <= 2 * i - 1; j++)
			{
				System.out.print("*");
			}
			System.out.println();
		}
	}

Are you sure? For i ==1 the last loop should print one single star ...

kind regards,

Jos

[YiBoog]

Yes...I just ran it several times with the same result. The last single asterisk at the end does not print. I don't know where else the problem could be??:eek:

[YiBoog]

Nevermind~ I found the problem. It was in the beginning FOR loop of the bottom triangle that was giving fits for each line. I converted > to >= and it printed the last star. Wooohoooo, Thank you again for your assistance!!! :D

// for each line of the bottom
		for (int i = len - 1; i >= 1; i--) //instead of > I changed to >=
		{			
			// print spaces for bottom

Very respectfully,

Boog

[JosAH]

Nevermind~ I found the problem. It was in the beginning FOR loop of the bottom triangle that was giving fits for each line. I converted > to >= and it printed the last star. Wooohoooo, Thank you again for your assistance!!! :D

You are welcome of course but the code you posted was not the code you were staring at on your computer (see above).

kind regards,

Jos