While-loop problem

[jimmy-lin]

    /**
     *  Write the method repeatSeparator().
     *  
     *  @param word the first String parameter.
     *  @param sep the second String parameter.
     *  @param count the number of times to repeat the word.
     *  @return a new String as described below.  
     * 
     *  Given two strings, word and a separator, return 
     *  a big string made of count occurrences of the word, 
     *  separated by the separator string.
     *  
     *  Here are some examples:
     *      repeatSeparator("Word", "X", 3) returns "WordXWordXWord"
     *      repeatSeparator("This", "And", 2) returns "ThisAndThis"
     *      repeatSeparator("This", "And", 1) returns "This"
     */

Can some one tell me what I did wrong here?

    public String repeatSeparator(String word, String sep, int count) 
    {
    	String result = "";
    	
    	int i = 0;
    	while (i < count)
    	{
    	if( i < count - 1)
    	result += word + sep;
    	else
    	result += word;
    	
    	i++;
    	}
    	
    	return result;
    	
}

[Fubarable]

Why do you think you've done something wrong? Let's see the program where you test this method.

[jimmy-lin]

I'm using check result that my teacher has given out to every homework assignment to test if my code run correctly.

When I try to check if i did it correctly.

This is what I got. I did use the while loop method, I just don't know why it doesn't read.

Testing method repeatSeparator in student class WhileLoopProblems
--------------------------------------------------------------------------------
  X This method should use while loops exclusively.
--------------------------------------------------------------------------------
   No tests run: (0%)

[CodesAway]

It works for me. The implementation isn't that readable, but that's a different question.

I would comment that using a String (instead of a StringBuilder) is inefficient.


Is the problem that you were expecting a static method (it's declared non-static)?

[jimmy-lin]

It works for me. The implementation isn't that readable, but that's a different question.

I would comment that using a String is inefficient.


Is the problem that you were expecting a static method (it's declared non-static)?

well, my teacher want me to return a different String.

Okay i just play around with the codes and it read somehow, but i still miss one

here is the codes

   public String repeatSeparator(String word, String sep, int count) 
    {
    	String result = "";
    	

        int i = 0;
        while (i < count) 
        {
        if ( i < count - 1)	
          result += word + sep;
          i++;
        }
       
        result += word;
        
    	
    	return result;
    	
}

Test result

Testing method repeatSeparator in student class WhileLoopProblems
--------------------------------------------------------------------------------
  X repeatSeparator("AAA", "", 0)-> expected:<[]> but was:<[AAA]>
--------------------------------------------------------------------------------
   10/11 tests passing (91%)

[Fubarable]

well, my teacher want me to return a different String.

If you used a StringBuilder, your method would return a String, it would return the results returned from the StringBuilder object's toString method. But I think that with your simple method, I wouldn't worry about using StringBuilder. Just concatenate Strings as you are doing as you really won't see much improvement in your program unless the method were concatenating hundreds of Strings or more.

[jimmy-lin]

ahh I figure it out, problem solve, thanks again for all your help.