Help With Scanner

[jtmoney0511]

I trust I'm posting this in the right forum. You nice people do consider 3 semesters of java still "new," right??

Anyway, I'm having a problem with Scanner. I have my program prompting me for a file name, and when I type in a file name and hit enter, the program does not seem like it's going to the next step. Now, when I step through in debug mode, it looks like it's making it to a few lines down, where I start scanning the file and counting the number of lines. But my lines variable goes waaaaay past the true number of lines in the file.

Anyway, what I don't understand, mainly, is why my program seems to get stuck. Is it because it's counting the lines? Also, why does it keep incrementing? My file has 10 lines...

Here's my code:

Java Code

  
  public static void main(String[] args)
  {
    String filename; 
	 int lines = 0;
    Scanner input_scan = new Scanner(System.in),
	         file_scan;
				   	 
    System.out.print("Enter a file name: ");
	 filename = input_scan.next();
	 
	 file_scan = new Scanner(filename);
	 while (file_scan.hasNextLine())
	   lines++;

Here is everything in the text file I'm scanning:

1234 23 widget1
3456 123 widget2
4356 45 widget3
1056 1234 widget4
9999 237 widget5
9322 22 widget6
5322 755 widget7
3422 2 widget8
3333 95 widget9
1111 15 widget10

That's it.

Any help would be greatly appreciated!

[Fubarable]

Where are you reading in the lines from the file? It appears that you've truncated the code that you've posted. Oh, by the way, I've placed code tags in your code, something you may wish to do yourself in future posts.

Much luck

[jtmoney0511]

Fubarable.. nice name. heh :)

I thought I had put code tags around my code. *confused*

Anyway, here's where I am counting the lines (but not yet saving them anywhere):

	 
while (file_scan.hasNextLine())
  lines++;

[Fubarable]

while (file_scan.hasNextLine())
  lines++;

This never gets a nextLine and so will never progress and will loop forever.

If you just want to count lines, at least do this:

while (file_scan.hasNextLine()) {
  lines++;
  file_scan.nextLine();  // get the line and discard it.
}

Also, always enclose loop blocks and control blocks in curly braces. This will help when you want to add more code.

[jtmoney0511]

I get it now. I didn't realize that I had to discard the one line to get it to count the next. Thank you so much!!

[Fubarable]

I think that the Scanner has an internal pointer or placeholder pointing to where it currently is located in the file. Your initial code has that placeholder set at the very top of the file, and you continually ask the scanner if there are more lines to read but don't move the placeholder, so it will continue to say "yes" forever.

[jtmoney0511]

I see. That makes a lot of sense.

[jtmoney0511]

Now I'm getting a FileNotFoundException at compile time (bolded part)! How does it know the file can't be found when I haven't even given the file name yet?

I don't understand this stuff.

import java.util.Scanner;
import java.io.*;

public class RecordSorter
{
  static int compare_count, move_count; 
			 
  public static void main(String[] args) throws FileNotFoundException
  {
    String filename, p_name; 
	 int lines = 0, p_num, p_qty;
    Scanner input_scan = new Scanner(System.in),
	         file_scan;
				   	 
    System.out.print("Enter a file name: ");
	 [b]filename = input_scan.nextLine();[/b]
	 input_scan.close();
	 
	 file_scan = new Scanner(new File(filename));
	 while (file_scan.hasNextLine())
	 {
	   lines++;
		file_scan.nextLine();
    }		
	  
    Record[] records = new Record[lines];
	 
	 for (int i = 0; i < records.length; i++)
	 {
	   p_num = file_scan.nextInt();
		p_qty = file_scan.nextInt();
		p_name = file_scan.next();
	   records[i] = new Record(p_num, p_qty, p_name);
	 }				
    insertionSort(records);
	 for (int i = 0; i < records.length; i++)
	   System.out.println(records[0]);	 		 
  }

  public static void selectionSort(Record[] data)
  {
    compare_count = 0;
    move_count = 0;
	 
    int min;
	 Record temp;
	 
	 for (int index = 0; index < data.length - 1; index++)
	 {
	   min = index;
		for (int scan = index + 1; scan < data.length; scan++)
		{
		  compare_count++;
		  if (data[scan].getNum() < data[min].getNum())
		    min = scan;
		}  	 
		
		temp = data[min];
		data[min] = data[index];
		data[index] = temp;
		move_count += 3; 	 
	 }
  }
  
  public static void insertionSort(Record[] data)
  {
    compare_count = 0;
    move_count = 0;
	 
    for (int index = 1; index < data.length; index++)
	 {
      int key = data[index].getNum();
		int position = index;
		
		while (position > 0 && data[position - 1].getNum() > key)
		{
		  compare_count++;
		  data[position] = data[position - 1];
		  move_count++;
		  position--;
      }
		data[position] = data[index];
		move_count++;
	 }	  
  
  }
}

[Fubarable]

This doesn't make sense as this error can't be thrown at compile time. Can you print the exact error message?

[jtmoney0511]

Oh nevermind. I just needed a throws clause. Oops! :)

[jtmoney0511]

By the way, the error said:

RecordSorter.java:19: unreported exception java.io.FileNotFoundException; must be caught or declared to be thrown
file_scan = new Scanner(new File(filename));