exception error

Code:

---

/**
  * Get the value at the given index in this list.
  * @throws IndexOutOfBoundsException if index is not in [0..size-1]
  */

public int get(int index) throws IndexOutOfBoundsException{
  if(index>=values.length){
    throw new IndexOutOfBoundsException ("index is bigger than array");
  } else if(index<0){
    throw new IndexOutOfBoundsException ("index is smaller than 0");
  } else {
    return values[index];
    // this should only return values explicitly added or set
  }

---

I'm trying to throw IndexOutOfBoundsException when index is bigger than array or smaller than 0.
So I ran this through the tester that prof gave us, but it reads as 'no exception' and fails the program..
What did I do wrong in this code?

thank you in advance

Other than missing a closing parenthesis, it looks good to me. Could there be a problem in the tester method?

I figured out the problem, I was suppose to use Size() instead of values.length.
but now I have another problem..

Code:

---

StringBuilder a = new StringBuilder("[ ");
  for(int i = 0; i <values.length; i++){
    if(i<values.length-1) {
      a.append(values[i] + ", ");
    } else {
      a.append(values[i]);
    }
  }
  a.append(" ]");
  return a.toString();
 }

---

It is suppose to print out array like [3, 4, 5, ,6 ] etcetc..
I'm very new to using StringBuilder.. so I tried to copy from one of the notes I took in class. But again, it said 'fail' in the tester program.
Did I make a mistake somewhere..?

This line is wrong:

Code:

---

if(i<values.length-1) {

---

should it be

Code:

---

if(i != values.length-1) {  // if not the last value

---

since you want to add a comma delimiter if you are not at the last value.

Quote:

---

Originally Posted by kira137

I figured out the problem, I was suppose to use Size() instead of values.length.
but now I have another problem..

Code:

---

StringBuilder a = new StringBuilder("[ ");
  for(int i = 0; i <values.length; i++){
    if(i<values.length-1) {
      a.append(values[i] + ", ");
    } else {
      a.append(values[i]);
    }
  }
  a.append(" ]");
  return a.toString();
 }

---

It is suppose to print out array like [3, 4, 5, ,6 ] etcetc..
I'm very new to using StringBuilder.. so I tried to copy from one of the notes I took in class. But again, it said 'fail' in the tester program.
Did I make a mistake somewhere..?

---

What type is the variable, values? I tested it with an int[], and it works fine(after removing the extra '}' at the end, not sure if that's the error).

Code:

---

import java.util.Arrays;

/**
 * A test
 */
public class Test
{
        /**
        * @param args
        *            not used
        */
        public static void main(String[] args)
        {
                int[] values = new int[] { 3, 4, 5, 6 };

                // did you mean to have a space after the '['
                StringBuilder a = new StringBuilder("[ ");
                for (int i = 0; i < values.length; i++) {
                        if (i < values.length - 1) {
                                a.append(values[i] + ", ");
                        } else {
                                a.append(values[i]);
                        }
                }
                // did you mean to have a space before the ']'
                a.append(" ]");

                System.out.println(a.toString());

                // why not use Arrays.toString method (requires Java 1.5+)
                System.out.println(Arrays.toString(values));
        }
}

---

thank you for the replies.. but the tester still fails my code. The values array is int-
Perhaps I should use string..?
Ah, I forgot the comment for toString() requirement
toString() is suppose to do this:

/**
* Convert this list to a String.
* For example: "[ 3, 15, 0, 22 ]"
*/
public String toString() {
(mycode from above)
}