Input help

[rice]

Hey guys, I'm coding a homework assignment

I'm trying to make the session lok like this:
A session might look like this:


Year >>2100 ***
Value must be between 2001 and 2025
Year >>2010


This is what I have so far for the main class

import java.util.Scanner;
public class Packages
{	
	public static void main(String[] args)
	{
		Scanner keyboard = new Scanner(System.in);
		System.out.print("Year>> ");
		int year = keyboard.nextInt();
	} 

	private static int getYear(Scanner keyboard, int year)
	{		int newYear;
			newYear = year;
			if (newYear < 2001 && newYear > 2005)
				System.out.println("Year should be between 2001 and 2005"); 
			
			return year;
}

Hehe, it doesn't work though.
I've tried to create a private class inside that method which was suggested by my teacher.

private static int GetInt(input, "Year", 2001, 2005)

I tried to use that instead of

private static int getYear(Scanner keyboard, int year)

I would so greatly appreciate any help from you guys.
Thanks you!

[Tolls]

What you've posted doesn't compile (missing bracket), but at least you used code tags!
You have my eyes undying gratitude for that...:)

Anyway, with what you've posted, you never actually call getYear().

[Eranga]

First compile your code and see there are any errors in your application. As Tolls says, there are few. And then read the error messages carefully, you can have an idea what's wrong in your code.

Good luck!

[atom86]

What you've posted doesn't compile (missing bracket) [...]
Anyway, with what you've posted, you never actually call getYear().

Exactly ..and you didn't close the bracket of the method getYear! i suggest you to use an IDE like NetBeans or Eclipse to simply fix this little mistakes..

anyway.. in your main() ,perhaps you meant to do something like:

int year = Packages.getYear(keyboard.nextInt());

So your getYear prototype should be:

private static int getYear(int year)

because i don't see any reasons to pass keyboard as a parameter in a method where you don't use it.. do you agree?

[Eranga]

because i don't see any reasons to pass keyboard as a parameter in a method where you don't use it.. do you agree?

may be a bad design. ;)

[pkang]

I agreed with others your posted code is not syntactically correct, and you did not call getYear method either to validate the year input.

Your conditional expression to check the keyed-in year has error. You may want to use || instead of &&.

Something like this:

private static int getYear(int year)
{
     int newYear;
     newYear = year;
     if (newYear < 2001 [COLOR="Red"]|| [/COLOR]newYear > 2005)
     {
          System.out.println("Year should be between 2001 and 2005"); 
     }
			
    return year;
}

[rice]

Thanks so much for the suggestions guys.