while-loop stopping on first loop

[davester]

I have this code that is attempting to generate a code consisting of two 2 digit numbers (eg 56,27 ... 17,81 etc) between 10 and 99 that it sends to a validation class which returns if it is correct. I need the loop to continue attempting all possibilities until the connectionmanager class returns that it is correct, then it needs to stop.

Here's what I have so far

public class openspaceship
{
public static void main(String[] args)
    {
    connectionmanager conn = new connectionmanager();
    combination comb = new combination();
        int i = 10;
        while (i <= 99)
        {
            int j = 10;
            while (j <= 99)
         {
            comb.setCombo(i, j);
       if (conn.openDoor(comb))
            {
                System.out.println("Door opened, combination is " + i + j);
            }
                j++;
         }
                i++;
        }
    }
}

I tried putting a System.println above the set combo, and what it did was say 10,10 every time which makes me think that it is only looping once and not adding 1 to each value.

The problem is that It will never find the code and always gets it wrong stopping after one loop.

Can someone please amend this to function correctly. Or give some advice.

Thanks

[pbrockway2]

Perhaps you could post a SSCCE?

If you think i and j are not being incremented, this fact would be confirmed without needing the other classes.

[pbrockway2]

Just a point of style, code like this:

int z = 10
while (z <= 99) 
{
    // stuff here...

    // and eventually
    z++;
}

is more readable if you keep the declaration, initialisation, update and checking of z all on one line. Which you can do with:

for (int z = 10; z < 100; z++)
{
    // stuff here
}

[davester]

I commented out the IF statement, and then It generated the numbers as intended. So the problem is no longer in this class.

Want me to pastebin all 5 classes?

[pbrockway2]

Want me to pastebin all 5 classes?

No!

Well, that's just me... Others might be willing to track the problem down that way.

The best way I know to track down a problem is to construct a really minimal example of it. That's why I posted the SSCCE link. They take work and stepping back from your code - but that's precisely why they're valuable, You end up questioning your assumptions.

For instance if the problem in the code you originally posted was that the "Door opened" message was never printed although you expected it would be, that could be for all sorts of reasons - the two notable ones being that the combination was not one of the values you tried, or that the openDoor() method is not checking the combination as you intended.

[Singing Boyo]

Another note of style... class names, by rigid convention, begin with uppercase letters. Also one thing we definitely need to see is the openDoor(comdination) method, as it may be doing something unexpected. (for example, if it is blocking, an infinite loop is possible). However, an SSCCE would be even better

[emceenugget]

stick in more print statements when your loops start. your only existing print statement is inside a condition, so if this is evaluating to false, you don't know whether or not your loops are executing for whatever reason. given that your loops iterate through ints, i highly doubt they're being terminated early.