Class problem: getting incorrect output

[mgm2010]

The following is the code for calculating the range of a vehicle and it works perfect.

class Vehicle{
  int passengers;         // No of passengers
  int fuelCap;            //Fuel capacity
  int mpg;                //Miles per gallon
}

class VehicleOne{
  public static void main(String args []){
    Vehicle MiniVan = new Vehicle();   //create minivan object
    int range;
    //Assign values to the fields in minivan
    
    MiniVan.passengers = 20;  /* These are the 
    MiniVan.fuelCap    = 16;    variables, called members, of 
    MiniVan.mpg        = 21;   object MiniVan and are created by
                                      using dot(.) operators and are called
                                         object.member */
    
    
    range = MiniVan.fuelCap * MiniVan.mpg;
    
    System.out.println("Minivan can carry " + MiniVan.passengers +
            " with a range of " + range + "\n");
    
  }
}

And then, the code is modified for two vehicles and I get the output as 0 range for both vehicles.

class Vehicle{
	int passengers, fuelCap, mpg;   //Declare fuel capacity, miles per gallon etc
	}
	//The following class declares an OBJECT of the class vehicle
	
	class VehicleTwo{
		public static void main(String args []){
			Vehicle Van = new Vehicle();
			Vehicle Bus = new Vehicle();
			int range1, range2;
			
			//Assign values to the fields of the two vehicles
			Van.passengers = 20;
			Van.fuelCap    = 30;
			Van.mpg        = 15;
			
			Bus.passengers = 40;
			Bus.fuelCap    = 60; 
			Bus.mpg        = 10;
			
			//Calculate range assuming full tank
			range1 = Van.fuelCap * Van.mpg;
			range2 = Bus.fuelCap * Bus.mpg;
			
			System.out.println("The van can carry " + Van.passengers + 
			               "with a range of " + range1);
			System.out.println("The bus can carry " + Bus.passengers +
			                 "with a range of " + range2);                 
		}
	}

Where am I going wrong ??

[RamyaSivakanth]

Iam getting the below output for the above code
The van can carry 20with a range of 450
The bus can carry 40with a range of 600

[kbindumadhavi]

Your code is perfect. It will not print range as 0

[Fubarable]

It calculates fine for me, but I would strongly recommend that you place the range calculation within the Vehicle class rather than reproduce the code each time you need it.

Something like:

class Vehicle
{
  int passengers;
  int fuelCap;
  int mpg; 
  
  public Vehicle(int passengers, int fuelCap, int mgp)
  {
    this.passengers = passengers;
    this.fuelCap = fuelCap;
    this.mpg = mgp;
  }
  
  public int calcRange()
  {
    return fuelCap * mpg;
  }
}

then just call calcRange() on any vehicle object when you want to know its range.

[corlettk]

Spot the problem now?



Putz!

Don't know what the (competent) posters above where talking about. Brain-farts all round, IMHO.

Cheers. Keith.

[mgm2010]

I was using JCreator and it is still giving '0' output. On Eclipse, however, I am getting the correct output. Perhaps, there is some bug in JCreator.
2. Is there any free and reliable IDE other than Eclipse ??(Let me study the 'sticky thread' and I shall come back for advice.

[CJSLMAN]

I think Keith wanted you to see this:
http://image74.webshots.com/174/2/74...2BTTEzo_ph.jpg
Don't know if you've corrected the range of the comment (/* */) in your code

Luck,
CJSL

[Fubarable]

I didn't looked carefully at the first code tagged segment, just the second one as that was the code he was having problems with. I now see the problem in the first section, but I don't see how that will effect the code in the second section that he states is not calculating well. It still should calculate fine.

[angryboy]

I was using JCreator and it is still giving '0' output. On Eclipse, however, I am getting the correct output. Perhaps, there is some bug in JCreator.
2. Is there any free and reliable IDE other than Eclipse ??(Let me study the 'sticky thread' and I shall come back for advice.

You prob don't have JCreator setup to run the second file. So the errors are from the first file. (which are cause by incorrect comments).

More reasons why beginners shouldn't use IDE's huh keith.

[Singing Boyo]

well... hate to break it to u all, but IDE's save noobs more than they condemn them. (at least Eclipse does, saved me more than once) As for IDE's other than Eclipse, there is NetBeans... but I've never looked at it, so can't tell you how good it is. It is Sun's IDE for Java, so it can't be too bad.