[SOLVED] if-else and boolean issues

[AngrYkIdzrUlE]

Hey im trying to get this code to accept time in 24 hours and charge calls according to peak time and non-peak time but the output for non-peak hours is the same as peak which shouldnt be, please help.

import java.util.Scanner;

public class PhoneCalls
{
	public static void main(String[] args)
	{
		Scanner key = new Scanner(System.in);
		
		System.out.print("Enter time in 24-hour mode(NEGATIVE integer to quit): ");
		int timeStart = key.nextInt();
		
		int numOfCall = 0; // initialise the number of calls made
		double totalCost = 0.0; 
		int hours = (timeStart/100); // separates the time
		int minutes = (timeStart%100);
		int length = 0;// initialise the length of call
		
		double callCost = 0.0;
		//loop begins here
		while (timeStart >= 0) 
		{
			
			
			System.out.print("Enter distance on Kilometres: ");
			int distance = key.nextInt();
			System.out.print("Enter length of call in minutes: ");
			length = key.nextInt();
			
			
			//limits 
			if (timeStart >= 7 || timeStart <= 19) // peak hours
			{
				if (distance > 60) // Trunk (STD) calls
				{
					callCost = 0.50;
				}
				else // local calls
				{
					callCost = 0.20;
				}
			}
			else if (timeStart < 7 && timeStart > 19) // non-peak hours
			{
				if (distance > 60) // Trunk (STD) calls
				{
					callCost = 0.25; 
				}
				else // local calls
				{
					callCost = 0.10;
				}
			}
			
			double costPerCall = total(length, callCost); // calculates the cost per call
			
			totalCost+=costPerCall;
			numOfCall++;
			
			System.out.println("The call will cost RM "+ costPerCall);
			
			System.out.println();
			System.out.print("Enter time in 24-hour mode(NEGATIVE integer to quit): ");
			timeStart = key.nextInt();
		}
		
		System.out.println("The total cost for all calls is RM" + totalCost);
			
			
	}	
	
	public static double total (int value1, double value2)
	{
		double total = (value1*value2);
		return total;	
	}
}

[Eric Golf]

Hi,

Give a number that IS NOT >=7 OR <=19

Give a number that IS < 7 AND > 19

Hope this helps,

Eric

[AngrYkIdzrUlE]

Hi,

Give a number that IS NOT >=7 OR <=19

Give a number that IS < 7 AND > 19

Hope this helps,

Eric

Thanks, i always end up messing up with the operators...mhh...gotta find an easy way to remember. :P

[Eranga]

Actually those are very basis in Java fundamentals. About operators. Not much difficult to remember. Best thing you can do is write all those such things on a paper and keep going for few times.

[AngrYkIdzrUlE]

Actually those are very basis in Java fundamentals. About operators. Not much difficult to remember. Best thing you can do is write all those such things on a paper and keep going for few times.

thanks, will do...
Have to test it and see if the code works, me such a noob :P

[Eranga]

Just have a try lol. As you want to workout, practice make perfect all the way. :)

[AngrYkIdzrUlE]

it still doesnt give correct output, here's what i want to get:

Enter time in 24-hour mode (NEGATIVE integer to quit): 0800
Enter distance in kilometres: 50
Enter length of call in minutes: 10
That call will cost RM2.00
Enter time in 24-hour mode (NEGATIVE integer to quit): 0
Enter distance in kilometres: 50
Enter length of call in minutes: 10
That call will cost RM1.00
Enter time in 24-hour mode (NEGATIVE integer to quit): 2222
Enter distance in kilometres: 70
Enter length of call in minutes: 10
That call will cost RM2.50
Enter time in 24-hour mode (NEGATIVE integer to quit): 1030
Enter distance in kilometres: 80
Enter length of call in minutes: 10
That call will cost RM5.00
Enter time in 24-hour mode (NEGATIVE integer to quit): 2020
Enter distance in kilometres: 60
Enter length of call in minutes: 11
That call will cost RM1.10
Enter time in 24-hour mode (NEGATIVE integer to quit): 900
Enter distance in kilometres: 61
Enter length of call in minutes: 11
That call will cost RM5.50
Enter time in 24-hour mode (NEGATIVE integer to quit): -999
The total cost of these calls is RM17.10
Average cost is RM2.85
Enter time in 24hr mode (NEGATIVE integer to quit): -999

[Eranga]

So you want to exit the code if user given a negative number, is it?

[AngrYkIdzrUlE]

yes thats the main idea but thats not the problem, try and run it and see...the value of non-peak time doesnt work.

[Eranga]

Yes, it's wrong. You have made a big mistake there.

else if (timeStart < 7 && timeStart > 19)

Can you tell me the meaning of this line of code. Do you know the meaning of &&?

[AngrYkIdzrUlE]

Yes, it's wrong. You have made a big mistake there.

else if (timeStart < 7 && timeStart > 19)

Can you tell me the meaning of this line of code. Do you know the meaning of &&?

&& is AND right?? im a newbie...well, basically what i want it to do is to take values out of the range between 7 and 19. How do i do that?? :P

[emceenugget]

if you have a condition where x < 7 and x > 19, then you will never get true. no number is less than 7 but greater than 19. you wanna use or.

[AngrYkIdzrUlE]

if you have a condition where x < 7 and x > 19, then you will never get true. no number is less than 7 but greater than 19. you wanna use or.

:P..oh, ok. As i said, i really SUCK when it comes to operators, boolean must be laughing his ass off. :(

[Eric Golf]

Hi,

Obviously my first post was too subtle :D

Have you figured it out, did you get it fixed?

Eric.

Edit - p.s. You don't actually need the second If, you can just use Else since if a number is not between 7 & 19 then it must be less than 7 or greater than 19.

[AngrYkIdzrUlE]

Hi,

Obviously my first post was too subtle :D

Have you figured it out, did you get it fixed?

Eric.

Edit - p.s. You don't actually need the second If, you can just use Else since if a number is not between 7 & 19 then it must be less than 7 or greater than 19.

Well, i could just have one if-else but the general idea is to limit entries to 24-hour system FIRST, meaning valid entries should be from 0000-2359, then after that criteria has been met then it checks if it's peak time or not.

[AngrYkIdzrUlE]

i think this time i got it right, the timeStart limit shouldn't have been 7, and 19. I changed them to 700 and 1959 cause the user enters 24-hours...anyways...test it out for me again...i think it works, Here's the code: PS, thanks all for the help

import java.util.Scanner;

public class PhoneCalls
{
	public static void main(String[] args)
	{
		Scanner key = new Scanner(System.in);
		
		System.out.print("Enter time in 24-hour mode(NEGATIVE integer to quit): ");
		int timeStart = key.nextInt();
		
		int numOfCall = 0; // initialise the number of calls made
		double totalCost = 0.0; 
		int hours = (timeStart/100); // separates the time
		int minutes = (timeStart%100);
		int length = 0;// initialise the length of call
		
		double callCost = 0.0;
		//loop begins here
		while (timeStart >= 0) 
		{
			
			
			System.out.print("Enter distance on Kilometres: ");
			int distance = key.nextInt();
			System.out.print("Enter length of call in minutes: ");
			length = key.nextInt();
			
			
			//limits 
			if (timeStart >= 700 && timeStart <= 1959) // peak hours
			{
				if (distance > 60) // Trunk (STD) calls
				{
					callCost = 0.50;
				}
				else // local calls
				{
					callCost = 0.20;
				}
			}
			else if (timeStart < 700 || timeStart > 1959) // non-peak hours
			{
				if (distance > 60) // Trunk (STD) calls
				{
					callCost = 0.25; 
				}
				else // local calls
				{
					callCost = 0.10;
				}
			}
			
			double costPerCall = total(length, callCost); // calculates the cost per call
			
			totalCost+=costPerCall;
			numOfCall++;
			
			System.out.println("The call will cost RM "+ costPerCall);
			
			System.out.println();
			System.out.print("Enter time in 24-hour mode(NEGATIVE integer to quit): ");
			timeStart = key.nextInt();
		}
		
		System.out.println("The total cost for all calls is RM" + totalCost);
			
			
	}	
	
	public static double total (int value1, double value2)
	{
		double total = (value1*value2);
		return total;	
	}
}

[Eranga]

Suggestion here. Take a peace of paper and write down your logic you want to evaluate on your application. Then try to put that logic in to a Java code. It make sense a lot. Just think about a step at a time. Mean time you can study bit about logical operators in Java.

[AngrYkIdzrUlE]

Suggestion here. Take a peace of paper and write down your logic you want to evaluate on your application. Then try to put that logic in to a Java code. It make sense a lot. Just think about a step at a time. Mean time you can study bit about logical operators in Java.

Thanks, i did that for the last part and got the code to work very easily..normally i just throw every idea in as they come...and end up with scrambled code.

[Eranga]

normally i just throw every idea in as they come...and end up with scrambled code.

That's not good lol. If you are going to change your code time to time, the way you work on is not good. Try to look at some concepts on OO.

By the way, did you solve your questions completely here?

[AngrYkIdzrUlE]

That's not good lol. If you are going to change your code time to time, the way you work on is not good. Try to look at some concepts on OO.

By the way, did you solve your questions completely here?

Thanks, i should. Yes i solved the questions. Thanks for all the help. I still have to do some small modification of the code...so maybe will need some help later. :D