2 converting errors

[Juicer]

hey guys,

i need your help. i am writing a torch program.
getting those errors while compiling:
Type mismatch: cannot convert from int to char
Type mismatch: cannot convert from int to boolean
pls. check the lines in my code. i would be thankful if you guys can help me out.

package lamp;
import java.io.*;

public class Lamp {
	public Lamp(){
		LampSwitch = 0;
		Lamp = 1;
		Battery = 1; 
		}
	public void LampOff(){
		LampSwitch = 0;
			}
	public void LampOn(){
		LampSwitch = 1;	
		}
	public int glowing(){
		if(Lamp == 1 && LampSwitch == 1 && Battery == 1){
			return 1;
			}
		else{
			return 0;
			}		
		}
	private int Battery;
	private int Lamp;
	private int LampSwitch;
	public static void main(String[] args){	
		char z = 'a';
		//int i = (int) z;
		Lamp t1;
		t1 = new Lamp();
		System.out.println("e..on a..off x..end\n");
		do{

			z = System.in.read(); // ERROR 1:         Type mismatch: cannot convert from int to char
			if(z == 'e') t1.LampOn();
			if(z == 'a') t1.LampOff();
			if(t1.glowing() == 1){ 
				System.out.println("Lamp on.");
				}
			else{
				System.out.println("Lamp off.");
				}	
			}while(z!='x');
		}
	}

gracias

[Fubarable]

You're not going to get very far trying to get user input using naked System.in. Just don't do it. Instead you might wish to read up on getting input from the user using a Scanner object.

[Supamagier]

if(t1.Glowing()){ // Error 2:         Type mismatch: cannot convert from int to boolean

public int Glowing(){

The method Glowing() (which should be glowing(), btw) returns an int. This means you can't use t1.Glowing(), since that only works with a boolean.

Either use

if (t1.Glowing() == 1)

or use

public int Glowing(){
    return (Lamp == 1 && LampSwitch == 1 && Battery == 1);	
}

Btw, please read The Java Code Conventions

[CJSLMAN]

LampSwitch = 0;
Lamp = 1;
Battery = 1;

You need to declare the type of your variables (in the constructor)... int's anybody?

Luck,
CJSL

[Juicer]

thanks for your reply guys!

You're not going to get very far trying to get user input using naked System.in. Just don't do it. Instead you might wish to read up on getting input from the user using a Scanner object.

why naked? i have also tried the scanner system, but it didnt work for me.

@Supamagier
true-false system didnt work. only this thing worked for me: if (t1.Glowing() == 1)
why does this work in c++ and not in java?

@ CJSLMAN
they are already in the constructor.

[CJSLMAN]

@ CJSLMAN
they are already in the constructor

huh... has your code changed? If so please post. The example that's posted your variable don't have a type defined.

CJSL

[Juicer]

not that much, but you can check it. i have updated my first post.
you said that i m missing some variables in the constructor, but they are there... see:

	public Lamp(){
		LampSwitch = 0;
		Lamp = 1;
		Battery = 1; 
		}

[Juicer]

i tried now something different.
instead of the line:

z = System.in.read();

i tried this one:

z = (char)System.in.read();

and now the error is no more, but another error is there:
Exception in thread "main" java.lang.Error: Unresolved compilation problem:
Unhandled exception type IOException

at lamp.Lamp.main(Lamp.java:39)

[Juicer]

problem solved... i tried with exceptions and its working. thanks everyone and also to this guy who helped me with exceptions.
i just replaced this line:

public static void main(String[] args){

with this one:

public static void main(String[] args) throws Exception{

gracias

[CJSLMAN]

you said that i m missing some variables in the constructor, but they are there... see:

huh, no, I never said that you were missing some variables in the constructor.... I said your variables were missing their "type" declaration, but I just saw that they have been declared as class variables, so forget the comment.

Luck,
CJSL

[Juicer]

hehe ok :)