Any suggestions on what i need tp change for a proper output.

[PureAwesomeness]

I want my program to produce an output like this
for example: This program's array have 10 elements: 65, 50, 79, 58, 83, 91, 65, 98, 79, 79

and outputs
The number of times that 65 appears in the array: 2
Indices that 65 is located: 0 6
The number of times that 79 appears in the array: 3
Indices that 79 is located: 2 8 9

if none matches display "None"


my logics are correct of getting those numbers, im just having trouble to produce a proper output.
i need to change the highlighted codes , but how?
im stuck with this for sometimes and its making me mad!:mad::mad:

import java.util.Scanner;
	public class RedundantElements
	{
		public static void main (String[]args)
		{
	Scanner input = new Scanner(System.in);

	System.out.println("Enter an integer for n, ranging 10 and 30.");

		int inp = input.nextInt();

		int [] array = new int[inp];

		int [] newArr = assign(array);


System.out.println("The random values in an array with size "+array.length+" are:");
		displaynum(newArr);

		displayVaFq(newArr);
}
//assign random number to n size array
	public static int[] assign(int [] array)
		{
			int [] newArr = new int[array.length];
		for (int i =0; i<array.length; i++)
		{
			newArr[i] = (int)(Math.random()*51)+50;

		}
		 return newArr;
	 }//end of assign method

//display numbers
	 public static void displaynum(int [] array)
	 {
		 for (int j=0; j< array.length; j++)
		 {
			if ((j+1)%5==0)
			System.out.println(array[j]+" ");
			else
			System.out.print(array[j]+" ");
	 }//end of for
 }//end of void method

//display value and fequency
	public static void displayVaFq(int [] array)
	{
		int count=0;
		int loc = 0;
		for (int k=0; k<array.length; k++)
		{
			for (int L=0; L<array.length; L++)
				{
					if (array[k] == array[L] && k != L)
					{
						count++;
						loc = L;
		[COLOR="Green"]System.out.print("Indices that "+array[k]+" is located: ");
		System.out.println("\n"+loc+" ");
		System.out.println("The number of times that "+ array[k] + " appears in the array: "+count);
}//end of if
	else
	System.out.println("No value in the array appear more than once");
	}//end of second for[/COLOR]

}//end of first for

}//end of displayVaFq method

}

[angryboy]

1) don't use random # to test your code, use fixed #s first.
2) you are using "count" to count the repeats for all values in the array. you need to keep separate counts for each value. that also applies to "loc" that you used to keep track of the indices.
3) your print statements are in the inner loop, so it prints everytime while counting. you need the count to finish first, then print the final result.

[PureAwesomeness]

ok...i figured it someout and i modified the code and one more problem that in green code i dont want to displayed the last number of the code i want to display all the numbers that satisfied in the loop.

import java.util.Scanner;
	public class RedundantElements
	{
		public static void main (String[]args)
		{
	Scanner input = new Scanner(System.in);

	System.out.println("Enter an integer for n, ranging 10 and 30.");

		int inp = input.nextInt();

		int [] array = new int[inp];

		int [] newArr = assign(array);


System.out.println("The random values in an array with size "+array.length+" are:");
		displaynum(newArr);

		displayVaFq(newArr);
}
//assign random number to n size array
	public static int[] assign(int [] array)
		{
			int [] newArr = new int[array.length];
		for (int i =0; i<array.length; i++)
		{
			newArr[i] = (int)(Math.random()*51)+50;

		}
		 return newArr;
	 }//end of assign method

//display numbers
	 public static void displaynum(int [] array)
	 {
		 for (int j=0; j< array.length; j++)
		 {
			if ((j+1)%5==0)
			System.out.println(array[j]+" ");
			else
			System.out.print(array[j]+" ");
	 }//end of for
 }//end of void method

//display value and fequency
	public static void displayVaFq(int [] array)
	{
		int count=0;
		int loc = 0;
		int rep =0;
		for (int k=0; k<array.length; k++)
		{
			for (int L=0; L<array.length; L++)
				{
					if (array[k] == array[L] && k != L)
					{
						count++;
						[COLOR="seagreen"]loc = L;[/COLOR]
						rep = k;

}//end of if

	}//end of second for

}//end of first for
System.out.print("Indices that "+array[rep]+" is located: ");
[COLOR="SeaGreen"]System.out.println("\n"+loc+" ");[/COLOR]
System.out.println("The number of times that "+ array[rep] + " appears in the array: "+count);
}//end of displayVaFq method

}

[angryboy]

read #2 above.

[PureAwesomeness]

sorry i didnt check when i posted my second codes.

[PureAwesomeness]

2) you are using "count" to count the repeats for all values in the array. you need to keep separate counts for each value. that also applies to "loc" that you used to keep track of the indices.

i read #2 and i think thats only applied to count because i only want one number, as for loc (location)i want all the Ls in array[L] that is equals to array[K] or im just not clear of what you saying.

[angryboy]

if you want to hold more than one value, you will need more than one variable right. you have only 1 count and 1 loc, so you end up w/ only the last loop count and index.

[PureAwesomeness]

yea, but the number of variable that i need is unknown.

[angryboy]

study this example well, because alot of programing involves this kind of work.

  //display value and fequency
  public static void displayVaFq(int [] array)  {
    int[] mainCount = new int[array.length];
    java.util.Arrays.fill(mainCount,1);
    String[] loc = new String[array.length];
    java.util.Arrays.fill(loc,"");
    
    
    for (int k=0; k<array.length; k++)    {
      for (int L=k; L<array.length; L++)      {
        if (array[k] == array[L] && k != L && array[L] !=0)        {
          array[L] = 0; //clear array[L]
          mainCount[k]++;
          loc[k] += L + ", ";
        }//end of if
      }//end of second for
      //mainCount[k] = count;

    }//end of first for
    
    for(int i=0; i<array.length; i++){
      if(array[i] != 0){
        System.out.println("Indices that "+array[i]+" is located: ");
        System.out.println(i+", "+loc[i]);
        System.out.println("The number of times it appears in the array: "+mainCount[i]);
      }
    }
  }//end of displayVaFq method

[PureAwesomeness]

Thank you! this is very helpful!
but i haven't learn this yet "java.util.Arrays.fill(mainCount,1);" so i dont know what does it means.

[angryboy]

that fills the array w/ 1 instead of using a for loop. check out the api doc for more info.