Counter

[ks1615]

I'm trying to write a program that does the following:
A number is designated as int win = 1.
Then a random number is generated.
If the number matches the winning number (1) then a counter is added.
What my program continues to do is cotinually add rather than obey the if statement.
Basically if number matches 1, a counter i added and this loop continues until 20 random numbers.

import java.io.IOException;
import java.io.PrintWriter;
import java.io.File;
import java.util.Random;
public class BottleCapPrize
{
public static void main (String [ ] args) throws IOException
{
PrintWriter outFile = new PrintWriter(new File("montecarlo.txt"));
int number = 0;
int Matches = 0;
Random randNumList = new Random();
int win = 1;
for(int cap = 1; cap <= 20; cap++)
{
number = randNumList.nextInt(6);
if(win != number)
Matches++;
System.out.println(Matches);
}



}
}

[CJSLMAN]

Golden rule of programming... always place curly bracket ({}) after if, else and loop statements.
But the real problem is the comparation:

if(win != number)

here your saying "if win is not equal to number"

I think the statement should be:

if(win == number)

"if win is equal to number"

Luck,
CJSL

[Eranga]

And another good practice is variable naming convention. As a rule local variable names are started with lower letters.

Not like this.

int Matches = 0;

Mush better way is,

int matches = 0;

[ks1615]

Wow thanks, that fixed my issue!!

[CJSLMAN]

Welcome...

CJSL

[Eranga]

And please mark the thread solved. :)

[MK12]

(Top of the page -> click Thread Tools -> Click Mark This Thread As Solved)
-MK12