Simple array questions

[jigglywiggly]

Well I took a break from java even though I am a beginner and now my memory is a bit lacking, I forget things quick.

Anyway, here is the question

Create a method called majorityZeros, which takes an integer array as an input parameter. It should check to see if the array contains more zeros than non-zero values. If the array contains strictly more zeros, then majorityZeros should return true. Otherwise majorityZeros should return false.
Examples:
data:{0,4,7,0} ==> false
data:{0,4,7,0,0} ==> true
data:{0,4,7,0,1,3,3} ==> false


So I went ahead and wrote this

public boolean majorityZeros (int[] data) {
boolean tobereturned=false;
int cnt = 0;
int j = data.length;
for(int i = 0; i<data.length; i++) {
   if(data[i]==0) { 
      cnt++;
     } 
}
 if(cnt>data.length) {
 tobereturned=true;
 }

return tobereturned;
 
}

Anyone got any ideas?
On this input:
0 0 7 0 0 28

Your code said: false
The correct result: true

[angryboy]

thats because cnt will never be > data.length.
you have to use two counters. one for if data[i] ==0,
another for !=0.

[jigglywiggly]

Oh yeah lol, thanks.

[Fubarable]

Nothing to do with Java and all to do with pure logic. Come on now:

 if(cnt>data.length)

Edit: I'm a little slow with the response. But you don't need to counters here, just one. A divide by two will do fine.

[jigglywiggly]

Fixed if anyone cares

boolean tobereturned=false;
int cnt = 0;
int evil=0;
int j = data.length;
for(int i = 0; i<data.length; i++) {
  if(data[i]==0) { 
    cnt++;
  }else {
    evil++;
  }
    
}
if(cnt>evil) {
  tobereturned=true;
}

return tobereturned;

[MK12]

A better approach (in coding, not functionality), would be Fubarable's suggestion:
(RED TEXT: Erase, get rid of)(Green TEXT: things I changed)(Orange:comments)

boolean [COLOR="Green"]returnValue[/COLOR]=false; [COLOR="orange"]// changed from tobereturned[/COLOR]
[COLOR="Orange"]// to returnValue, describes its use better IMO[/COLOR]
int cnt = 0;
[COLOR="Red"]int evil=0;[/COLOR]
int j = data.length;
for(int i = 0; i<data.length; i++) {
  if(data[i]==0) { 
    cnt++;
  }[COLOR="red"]else {
    evil++;
  }[/COLOR]
    
}
if(cnt>[COLOR="Green"]data.lenth / 2[/COLOR]) { [COLOR="DarkOrange"]// changed from evil[/COLOR]
  returnValue=true;
}

return returnValue;

Hope this helped.
-MK12

[veens4444]

A better approach (in coding, not functionality), would be Fubarable's suggestion:
(RED TEXT: Erase, get rid of)(Green TEXT: things I changed)(Orange:comments)

boolean [COLOR="Green"]returnValue[/COLOR]=false; [COLOR="orange"]// changed from tobereturned[/COLOR]
[COLOR="Orange"]// to returnValue, describes its use better IMO[/COLOR]
int cnt = 0;
[COLOR="Red"]int evil=0;[/COLOR]
int j = data.length;
for(int i = 0; i<data.length; i++) {
  if(data[i]==0) { 
    cnt++;
  }[COLOR="red"]else {
    evil++;
  }[/COLOR]
    
}
if(cnt>[COLOR="Green"]data.lenth / 2[/COLOR]) { [COLOR="DarkOrange"]// changed from evil[/COLOR]
  returnValue=true;
}

return returnValue;

Hope this helped.
-MK12

Its correct