Help! - How to insert a new line to a text file

[matpj]

Hi all,

I have written a seimple program to test out a bigger idea.
This reads 2 columns from a database (about 477 rows at the moment)
and it then writes these to a text file.
I need to put each row on a new line in the text file but '\n' seems to just return a special character in the .txt

Can anybody suggest how I do this?
here is my code:

import java.sql.*;
import java.io.*;
import java.io.FileWriter;


class SimpleOraJava {
 
    public static void main(String args[]) throws SQLException, IOException {
    
        DriverManager.registerDriver(new oracle.jdbc.driver.OracleDriver());
    
        String serverName = "servername";
        int port = 1521;
        String user = "user";
        String password = "password";
        String SID = "nikuuat";
        String URL = "jdbc:oracle:thin:@" + serverName + ":" + port + ":" + SID;
    
        Connection conn = DriverManager.getConnection(URL, user, password);
        String SQL = "SELECT DSTI_PROJ_REF, id FROM NIKU.ODF_CA_PROJECT where dsti_proj_act = 'ADM'";
        Statement stat = conn.createStatement();
        ResultSet rs = stat.executeQuery(SQL);
        FileWriter fout = new FileWriter("c:\\test.txt"); //Create new file stream
    
        while (rs.next()) { //cycle through result set
              fout.write(rs.getString(1) + "\t"  + rs.getInt(2) + "\n");
        }
    
        fout.close();  //close file stream
    
        System.out.println("Complete");
        stat.close();
        conn.close();

  }

}

Thanks in advance,

Matt

[Supamagier]

Use a BufferedWriter

BufferedWriter bw = new BufferedWriter(new FileWriter("c:\\test.txt"));
bw.newLine();

:)

~Matt

[matpj]

thanks for the reply!
does that mean it cannot be done with FileWriter?

what are the pros/cons of BufferedWriter compared to FileWriter?

Thanks again,

Matt

[mtyoung]

from
BufferedWriter (Java 2 Platform SE 5.0)

Write text to a character-output stream, buffering characters so as to provide for the efficient writing of single characters, arrays, and strings.

In general, a Writer sends its output immediately to the underlying character or byte stream. Unless prompt output is required, it is advisable to wrap a BufferedWriter around any Writer whose write() operations may be costly, such as FileWriters and OutputStreamWriters. For example,

[Eranga]

With FileWriter you can use system properties as well.

String newLine = System.getProperty("line.separator");

Then simply write this newLine once you write a line of text.

[matpj]

Thanks for that - it works brilliantly.

Whilst I am at it, I need to actually make some of the fields a fixed length on the text file. Is this easy to acheive with the code I currently have (above)?

thanks in advance,
Matt

[Eranga]

Can you bit more clearly explain what you want to do here? Are you want to make the fixed length on the file text? What that file content, and how those data added to the file?

[matpj]

Can you bit more clearly explain what you want to do here? Are you want to make the fixed length on the file text? What that file content, and how those data added to the file?

Hi,
in the code above, I am selecting 2 columns, and writing them to the file with a tab seperating them.
The first of the two fields I am returning I want to make 32 characters (no matter how many come back from the database).
this will result in the value being padded to the right by a certain number of spaces.

for example, I currently get the following output:

INT5603BL	5000033
INT5700BL	5000035
TST14JAN	5000002
INT5200BL	5000019
INT5301BL	5000027
INT6002BL	5000170
INT4400BL	5000081
INT4000BL	5000083
INT1100BL	5000084

this is just two fields seperated with a tab.

I want to be able to say "give me the first field, but make sure the total length is 11 charaters, then give me the second field, making the output:

INT5603BL  5000033
INT5700BL  5000035
TST14JAN   5000002
INT5200BL  5000019
INT5301BL  5000027
INT6002BL  5000170
INT4400BL  5000081
INT4000BL  5000083
INT1100BL  5000084

The actual end result will be several fields all set to specified lengths (in my spec)
I have tried using:

fout.write(String.format("%11s",rs.getString(1)) + "\t"  + rs.getInt(2) + newLine);

but this pads the value to the LEFT making the total number of characters (including the value returned from the database) 11. I need the trailing spaces to the right.

Does this make sense?
Regards,
matt

[Supamagier]

Yea, it does, for me. ;) You could, of course, write a simple method to pad it to the right, it probably also can be done with some method similar to the one you used now, but I wouldn't know.

[matpj]

Can you bit more clearly explain what you want to do here? Are you want to make the fixed length on the file text? What that file content, and how those data added to the file?

Yea, it does, for me. ;) You could, of course, write a simple method to pad it to the right, it probably also can be done with some method similar to the one you used now, but I wouldn't know.

Hi,
well I have now found a method which seems to work ok:

public static String padRight(String s, int n) {
        return String.format("%1$-" + n + "s", s);
    }

being extremeley wet behind the ears when it come sto Java, i'm not exactly sure I am doing things the right (or best) way.

I've simply pasted that method above my Main method.
Everything is in the one class at the moment.
I'm sure it will work, but it seems a bit too amateur.
I'm trying to think wether I need to split things out into other classes - but i'm not sure if I can or need to...

[Eranga]

Formatting is the best you have to use. And I don't think you need to go for a separate class to do this formatting. It's just need if you want to use your own formatting process other than JDK APIs.

[sanusi]

I suggest, u can add "\r\n" into your source code

original code
fout.write(rs.getString(1) + "\t" + rs.getInt(2) + "\n");

replace with
fout.write(rs.getString(1) + "\t" + rs.getInt(2) + "\r\n");

[Fubarable]

I suggest, u can add "\r\n" into your source code

original code
fout.write(rs.getString(1) + "\t" + rs.getInt(2) + "\n");

replace with
fout.write(rs.getString(1) + "\t" + rs.getInt(2) + "\r\n");

And make your code work OK with Windows and not OK with Unix? No thank you. Eranga already suggested a better solution that is not OS-specific. Besides you're giving an incorrect answer to a thread that's over a year old.

Locking.

[Eranga]

Very old thread :P