[SOLVED] Problem with an If Statement.

Hey again.

I am trying to get a while loop to work only when it gets a certain string sent back to the server.

This is the code:

Code:

---

public void ServerCMDS(String NxtCmd) throws java.rmi.RemoteException
{
    i = 1;
    if (NxtCmd == "/ShowUsers") {
      while (i <= LoggedInCount) {
            System.out.println(UsersLoggedIn[i]);
            i++;
      }
      i = 0;
    }
}

---

Now if i print out the NxtCmd to the screen it shows exactly what i just typed. I.E. /ShowUsers

But for some reason the IF statement will not work, maybe im doing it wrong.

If i remove the if statement the while loop will run no problem.

Any ideas?

Thanks,
Chris

for value comparison in case of String , you should use equals or equalsIgnoreCase method, so your code should go as follows


public void ServerCMDS(String NxtCmd) throws java.rmi.RemoteException
{
i = 1;
if (NxtCmd.equalsIgnoreCase("/ShowUsers")) {
while (i <= LoggedInCount) {
System.out.println(UsersLoggedIn[i]);
i++;
}
i = 0;
}
}

Ah thanks so much, that works perfect!

yep, Id say thats it. using == for String compares addresses and not the string itself.

Quote:

---

Originally Posted by logicbug

yep, Id say thats it. using == for String compares addresses and not the string itself.

---

When i was searching for examples when it didn't work at first everyone i found all used numbers instead of things like strings and characters. Even the book i bought was using numbers so i just assumed it was like other programming languages i have used and used == to compare them.

:)

I did the same thing the first time I needed to compare a string in java, must have taken me 2 hours to figure out what was wrong lol it's not something you are likely to forget!

Just another quick question, Because at the moment im just getting it to relay messages on the servers console how do i make it so that the messages are sent to the client instead of displaying on the server?

For example if i type /ShowUsers on my client it actually displays them on the server and not the client.

Firstly "==" operator compares addresses i.e reference to object;for objects but works fine with non-objects type like int,long etc i.e primary data-types.
For String class "Equals" method is used to compare 2 strings
System.out stands for console (on server machine)
So you must write similar Sytem.out at client side java program.For that you will require server to send the list i.e UserLoggedIn array to client and then client will display that array using System.out

this is one of the most common issues people have with strings. another one you (and anyone else unfamiliar with java strings) might wanna look into is null vs. empty strings.