Incompatible types??? Counting through an array of Strings

[ookie833]

having a problem counting through an array of Strings. I am trying to count how many employee have the last name Smith.

final int EMPLOYEE=5;
Employee[] id= new Employee[EMPLOYEE];
id[0]=new Employee("john", "Smith");
id[1]=new Employee("Mary", "King");
id[2]=new Employee("Josh", "Smith");

My Code:



for (int index=0; index < id.length; index++)
{
String Last;
int count=0;
Last=id[index].getLastName();
if (Last=="Smith")
{
count+=id[index];
System.out.println("There are" + count + "with the last name Smith");
}


}

I get an error of incompatible types. int and String.???

[Nicholas Jordan]

common first code error, use String.equals("Smith");

and just do ++count or count++

[ookie833]

I changed the code to:

if (Last.equals("Smith"))
{
count++;
}


but now it just says 1 person was found with the last name smith instead of 2 people. Not sure why>

[Nicholas Jordan]

Not sure how the Employee class is coded but the code count+=id[index]; assigns a ( an ) EMPLOYEE to an int, you show code that changed that. You should get a null pointer exception on index++ when it gets past the three employees and arrives at the fourth position in the array, which does not have an employee new'd to that position. Sometimes this type of error is obscured by fancy tools, and in any event is best resolved by tediously walking through the code again and again till you find it.

Place a

System.out.println(Last);

above the if( string.equals) and see what the Last is actually getting.

Do this for testing.

Probably do println(count); also - see what is actually being produced.

This seems tedious, after about two of these you will really like the idea.