Arrays

[TheRocket]

Ok I have created the code but it wont compile, the error I get is n is not initialized can anyone help? Code is below.

import javax.swing.*;
public class ArrayTest
{
	public static void main(String[] args)
    {
        int[] numbers = new int[3];
        int count = getInput(numbers);

        for (int i = 0; i < count; i++)
        {
        	System.out.println(i + "\t" + numbers[i]);
        }
        System.exit(0);
    }

    public static int getInput(int[] numbers)
    {
        String input;
        int count = 0, n;

        while (count <= 2)
        {
            numbers[count] = n;
            count++;
            input = JOptionPane.showInputDialog(
                       "Enter a number");
            n = Integer.parseInt(input);
        }
	   return count;
    }
}

[neilcoffey]

To "initialise" means to "give an initial value to" a variable. When you create a local variable-- in other words, one that you define inside a method-- Java doesn't give it any initial value. In your code, you're trying to refer to n (in the line numbers[count] = n)before you've set any value to it.

By the way, you don't have to declare all your variables at the very top of the method (as you do in C, for example). In Java, you can generally just declare them where you first need to use them.

[TheRocket]

So I could just declare n as 0 and it would work?

[TheRocket]

Ok I have got it to compile, but now when I run it. It doesn't output what I want it to. Example: I input 3,4,5 it should output:

0 3
1 4
2 5

but instead it only outputs:

0 3
1 4

Code below.

public class ArrayTest
{
	public static void main(String[] args)
    {
        int[] numbers = new int[3];
        int count = getInput(numbers);

        for (int i = 0; i < count; i++)
        {
        	System.out.println(i + "\t" + numbers[i]);
        }
        System.exit(0);
    }

    public static int getInput(int[] numbers)
    {
        String input;
        int count = 0, n;
        
        input = JOptionPane.showInputDialog(
                   "Enter a number");
        n = Integer.parseInt(input);
        
        while (count < 2)
        {
            numbers[count] = n;
            input = JOptionPane.showInputDialog(
                       "Enter a number");
            n = Integer.parseInt(input);
            count++;
        }
	   return count;
    }
}

[neilcoffey]

So your problem is that the very last number isn't being added to the array. Try and think through step be step what happens on the last run through the while loop to figure out why this is.

[TheRocket]

Nope I can't think of anything except moving the count++; above the input box which still gives me the same output.

[xcallmejudasx]

First glance makes me think your while parameter has broken logic.
you have
numbers[0] = n
numbers[1] = n
return count

if you want your array to have 3 sections you need [0,2] not [0,2); meaning don't stop until you section 0, 1, AND 2 filled.