SQL update problem

[skiing]

I am having problems updating my sql database with java I am passing in a string value that I have converted from a int to a string and have the value for the colum set to text here is what I have

statement2 = "update Mortgage SET Number1 = '" + ic + "' WHERE ID = '" + 1 + "'";


it will erase what I have in there and leave a blank but wont insert like 5000, but right before it I print out a system.out.println(ic) and it prints out 5000.

[masijade]

Use PreparedStatement.

PreparedStatement (Java Platform SE 6)
Using Prepared Statements (The Java™ Tutorials > JDBC(TM) Database Access > JDBC Basics)

[Eranga]

How you convert an int value to string?

[skiing]

right out of the profesor's notes.

ic = Integer.toString(val);

[masijade]

Like I said, though, use PreparedStatement, it may or may not solve the current problem, but it will, at least, prevent many possible future problems.

If your instructor is telling you to cobble together a statement like this then you should shoot him for ineptitude. Cobbling together statements in this manner is just begging for problems (and SQL Injection attacks).

Edit: And yes, I know, you and your instructor (if he is the one that directed you to use this) will say, "It is only for now" and/or "for this example it doesn't matter". And you're right, unfortunately it breeds bad habits. Once you've learned to do it this way (and believe it to be the right way), you won't "change your stripes", so to say. Thereby running into all sorts of problems later. Do it right, now.

[skiing]

it works now I would have never tried that.

[Eranga]

Please mark the thread solved if you found the solution for your question.

[skiing]

I am very new here and I couldn't locate how to do it sorry.

[xcallmejudasx]

at the top of the post click thread tools then click on solved

[skiing]

I am a student doing a project for a class that the program I am writting is 80% of my grade and I have been basically teaching myself java by trial and error and little help from the profesor. You have helped answer two or three major stumbling points on my project that would not have been finished without your help.