Buffered Reader Exception

I cant understand where my program has gone wrong. It produces this error
deps-jar:
compile:
run:
IO Error! Stream closed
java.io.IOException: Stream closed
at java.io.BufferedReader.ensureOpen(BufferedReader.j ava:97)
at java.io.BufferedReader.readLine(BufferedReader.jav a:292)
at java.io.BufferedReader.readLine(BufferedReader.jav a:362)
at lab8.main(lab8.java:33)
BUILD SUCCESSFUL (total time: 0 seconds)

Here is the source code

/*
* To change this template, choose Tools | Templates
* and open the template in the editor.
*/



import java.util.Scanner;
import java.io.*;


public static void main(String[] args) {
try{
Scanner sc = new Scanner (System.in);

//Step 1: create and open file stream
FileReader openfile = new FileReader ("names.txt");
BufferedReader brstream = new BufferedReader (openfile);

//Step 2 : must write into new file
FileWriter fw1= new FileWriter ("small.txt");
BufferedWriter bw1 = new BufferedWriter (fw1);
PrintWriter pw1 = new PrintWriter (bw1);

FileWriter fw2= new FileWriter ("big.txt");
BufferedWriter bw2 = new BufferedWriter (fw2);
PrintWriter pw2 = new PrintWriter (bw2);

//Step 3: check length of name
String name = brstream.readLine();
while ( (brstream.readLine() != null) ){
if (name.length() < 5)
{pw1.println(name);}
else { pw2.println(name) ; }

//step 4: close all the stream
brstream.close();
pw1.close();
pw2.close(); } //close while
} //close try

catch(FileNotFoundException e)
{System.out.println("File not found!"+e.getMessage() );
System.exit(0);}

catch(IOException e)
{System.out.println("IO Error! "+ e.getMessage());
e.printStackTrace();
System.exit(0);}

}
}

Basically this program reads a text file "names.txt". There is one name in each line of the file with no whitespace characters. If the length of the name is less than 5, it is printed in "small.txt" else it is printed in "big.txt". Can anybody tell me what is wrong with my program?

Your close() statements are in the while loop. I think they should after your while loop.

I have already changed my program so that the pwstream is b4 the while loop. However, how my program reads only alternative names from my name.txt. Thereafter, it reads the null string and then produce an error message. Here it is

Name is Beckham
Name is Blanc
Name is Scholls
Name is McDonald
Name is BurgerKing
Name is PHut
Name is null
Exception in thread "main" java.lang.NullPointerException
at lab8.main(lab8.java:36)

Here is my original text file ("names.txt"):

Alex
Beckham
Giggs
Blanc
Neville
Scholls
Keane
McDonald
KennyRoger
BurgerKing
AandW
PHut

and here is my new program:

import java.util.Scanner;
import java.io.*;

public class lab8 {

/**
* @param args the command line arguments
*/
public static void main(String[] args) {
try{
Scanner sc = new Scanner (System.in);
//Step 1: create and open file stream
FileReader openfile = new FileReader ("names.txt");
BufferedReader brstream = new BufferedReader (openfile);
//Step 2 : must write into new file
FileWriter fw1= new FileWriter ("small.txt");
BufferedWriter bw1 = new BufferedWriter (fw1);
PrintWriter pw1 = new PrintWriter (bw1);

FileWriter fw2= new FileWriter ("big.txt");
BufferedWriter bw2 = new BufferedWriter (fw2);
PrintWriter pw2 = new PrintWriter (bw2);

//Step 3: check length of name
String name;
while ( (brstream.readLine() != null) ){
name = brstream.readLine();
System.out.println("Name is " + name);
if (name.length() < 5){pw1.println(name);}
else { pw2.println(name) ; }
}//close while

//step 4: close all the stream
brstream.close();
pw1.close();
pw2.close();}//close try

catch(FileNotFoundException e)
{System.out.println("File not found!"+e.getMessage() );
System.exit(0); }

catch(IOException e)
{System.out.println("IO Error! "+ e.getMessage());
e.printStackTrace();
System.exit(0);}

}
}

Thanks!

Hi I am facing a similar problem. The bufferdReader readLine() method seams to read alternate lines from the file. Can anyone explain why is it so?

public class ReadFile {

public static void main(String[] args){
File file= new File("c:\\b.txt");
try{
FileReader fileReader = new FileReader(file);
BufferedReader br = new BufferedReader(fileReader);
String line = "";
while((line = br.readLine()) != null){
System.out.println(br.readLine());
}

}
catch(Exception e){
e.printStackTrace();
}
}

Well... do you see the bit where you're calling readLine() twice but only printing once...?

Thanks a lot for the reply. It was that easy!

@hitman

Code:

---

while (brstream.readLine() != null) {
  name = brstream.readLine();
  System.out.println("Name is " + name);
  if (name.length() < 5)
      pw1.println(name);
  else
      pw2.println(name);
}

---

You made the same mistake neilcoffey found in parulrana9's code:

Quote:

---

Originally Posted by neilcoffey

Well... do you see the bit where you're calling readLine() twice but only printing once...?

---

And, please, USE CODE TAGS to wrap your code... It's quite difficult for us to read...