Reply
 
LinkBack Thread Tools Display Modes
  #1 (permalink)  
Old 10-22-2008, 06:09 PM
Member
 
Join Date: Oct 2008
Posts: 1
Rep Power: 0
Spitfire is on a distinguished road
Default Need some help plz
Hello, i have written this for part of uni course work and i am struggling to get it to work, can one else see any major problem with my work that they could point out to me.

import java.util.scanner
public class Calculate
{
public static void main( String args[] )
{

Scanner input = new Scanner ( System.in):

int number1: // first number
int number2: // second number
int number3: // third number
int largest: // largest value
int smallest: // smallest value
int sum: // sum of numbers
int product: // product of numbers
int average: // average of numbers

System.out.print("Enter first integer:")://Prompt
number1 = input.nextInt(); //read first number from user

System.out.print("Enter second integer:");//Prompt
number2 = input.nextInt(); //read second number from user

System.out.print("Enter third interger:");//prompt
number3 = input.nextInt(); //read third number from user

largest = number1:

smallest = number1:

if (number1 > number2 > number3)
System.out.printf("Largest is %d > %d\n", number1 number2 number3);

if (number1 < number2 <number3)
system.out.printf("Smallest is %d < %d\n", number1 number2 number3);

sum - number1 + number2 + number3
System.out.printf( "Sum is %d\n", sum ); // display sum

if ((number1 + number2 + number3)/3)
System.out.printf( "Average is %d\n", sum );

if (number1*number2*number3)


}


}//end of Method

I would be thankfull for any feedback as i am very new to java having only been doing it for a a couple of weeks now.

The idea behind it is that it should help to find the largest of three numbers, then the smallest the product the average and the sum.

Thanks
Bookmark Post in Technorati
Reply With Quote
  #2 (permalink)  
Old 10-22-2008, 06:15 PM
Eranga's Avatar
Moderator
 
Join Date: Jul 2007
Location: Colombo, Sri Lanka
Posts: 6,525
Rep Power: 9
Eranga has a spectacular aura aboutEranga has a spectacular aura about
Send a message via Yahoo to Eranga
Default
This is wrong,

Code:
if (number1 > number2 > number3)
actually done it wrong way.

Can you tell me what's the logic you have to solve this problem. Take a seat and spend a lots of time to design your application first. If you have a strong design coding is not difficult at all.
__________________
Use an appropriate Subject. "Help, urgent!" isn't one.
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.

Someone helped you?
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
their helpful post.
Help:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Resources:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Web:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Tips:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Bookmark Post in Technorati
Reply With Quote
  #3 (permalink)  
Old 10-22-2008, 06:18 PM
Eranga's Avatar
Moderator
 
Join Date: Jul 2007
Location: Colombo, Sri Lanka
Posts: 6,525
Rep Power: 9
Eranga has a spectacular aura aboutEranga has a spectacular aura about
Send a message via Yahoo to Eranga
Default
Oh my pal, there are lots of errors. How long you start to learn Java? You have misses lots of basis there in your code.
__________________
Use an appropriate Subject. "Help, urgent!" isn't one.
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.

Someone helped you?
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
their helpful post.
Help:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Resources:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Web:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Tips:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Bookmark Post in Technorati
Reply With Quote
  #4 (permalink)  
Old 10-22-2008, 06:28 PM
Eranga's Avatar
Moderator
 
Join Date: Jul 2007
Location: Colombo, Sri Lanka
Posts: 6,525
Rep Power: 9
Eranga has a spectacular aura aboutEranga has a spectacular aura about
Send a message via Yahoo to Eranga
Default
Just check the following code. Compare it with your code above.

Code:
import java.util.Scanner;
        
public class Calculate {

    public static void main( String args[] ) {

        Scanner input = new Scanner ( System.in);

        int number1; // first number
        int number2; // second number
        int number3; // third number    
        int largest; // largest value
        int smallest; // smallest value
        int sum; // sum of numbers
        int product; // product of numbers
        int average; // average of numbers

        System.out.print("Enter first integer:");//Prompt
        number1 = input.nextInt(); //read first number from user

        System.out.print("Enter second integer:");//Prompt
        number2 = input.nextInt(); //read second number from user

        System.out.print("Enter third interger:");//prompt
        number3 = input.nextInt(); //read third number from user

        // Make the number1 as maximum
        largest = number1;
        
        if(largest < number2)
            largest = number2;
        
        if(largest < number3)
            largest = number3;
        
        System.out.println("Maximum is: " + largest);
        
        // Make the number1 as minimum
        smallest = number1;
        
        if(smallest > number2)
            smallest = number2;
        
        if(smallest > number3)
            smallest = number3;
        
        System.out.println("Smallest is: " + smallest);

    } // End of method
} // End of class
__________________
Use an appropriate Subject. "Help, urgent!" isn't one.
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.

Someone helped you?
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
their helpful post.
Help:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Resources:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Web:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Tips:
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
|
To view links or images in signatures your post count must be 10 or greater. You currently have 0 posts.
Bookmark Post in Technorati
Reply With Quote
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On



All times are GMT +2. The time now is 10:13 PM.



VBulletin, Copyright ©2000 - 2009, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2009, Crawlability, Inc.
Copyright ©2006 - 2007, www.java-forums.org