'void' type not allowed here

[Torgero]

I cant seem to find out whats wrong. Anyone who could help me?

Error:
KontoTest.java:81: 'void' type not allowed here
showMessageDialog(null, "Dette tilsvarer " + olesKonto.uttak(Uttak) + " NOK.");

[masijade]

What is the return type of the method "olesKonto.uttak(String)"? void maybe? Was it maybe suppossed to be String?

[Torgero]

import static javax.swing.JOptionPane.*;


class Konto {
private long kontonr;
private String navn;
private double saldo;

public Konto(long startKontonr, String startNavn, double startSaldo) {
kontonr = startKontonr;
navn = startNavn;
saldo = startSaldo;
}

public long finnKontonr() {
return kontonr;
}

public String finnNavn() {
return navn;
}

public double finnSaldo() {
return saldo;
}

public void innskudd(double beløp) {
saldo = saldo + beløp;
}

public void uttak(double beløp) {
saldo = saldo - beløp;


}
}

[Fubarable]

What is the return type of the method "olesKonto.uttak(String)"? void maybe? Was it maybe suppossed to be String?

Looks like you were right on the money. It is a void return type.

To the original poster, you can't expect a method that returns void to be able to return a String. Either you have to use the method differently (call it without expecting a return type), or rewrite it to return the appropriate object (here a String).

[Torgero]

How do I do it? Cant seem to d
find out.

[masijade]

public void someMethod() {
}

The method above is a void method.

public String someMethod() {
    return "some String";
}

This is the same method with a String return type. Note the differences and make the same to your code.

[Torgero]

Ok, tried it and this was the new error:

java:30: missing return statement
}


import static javax.swing.JOptionPane.*;


class Konto {
private long kontonr;
private String navn;
private double saldo;

public Konto(long startKontonr, String startNavn, double startSaldo) {
kontonr = startKontonr;
navn = startNavn;
saldo = startSaldo;
}

public long finnKontonr() {
return kontonr;
}

public String finnNavn() {
return navn;
}

public double finnSaldo() {
return saldo;
}

public String innskudd(double beløp) {
saldo = saldo + beløp;
}

public String uttak(double beløp) {
saldo = saldo - beløp;


}
}


class KontoTest {
public static void main(String[] args) {


Konto olesKonto = new Konto(123456676756L, "Ole Olsen", 2300.50);


long kontonr = olesKonto.finnKontonr();
String navn = olesKonto.finnNavn();
double saldo = olesKonto.finnSaldo();

System.out.println("Før endring av dataene: \nKontonr: " + kontonr +
", navn: " + navn + ", saldo: " + saldo);


// olesKonto.innskudd(12000);
// olesKonto.uttak(5000);

String tekst = showInputDialog("Hvor mye settes inn:");
double beløp = Double.parseDouble(tekst);
showMessageDialog(null, "Dette tilsvarer " + olesKonto.innskudd(beløp) + " NOK.");



kontonr = olesKonto.finnKontonr();
navn = olesKonto.finnNavn();
saldo = olesKonto.finnSaldo();
System.out.println("Etter endring av dataene: \nKontonr: " + kontonr +
", navn: " + navn + ", saldo: " + saldo);


System.out.println(olesKonto.toString());
}
}

[masijade]

Take a closer look at my two example. I did more than just change the return type, I added a return statement as well, did you do that?

[emceenugget]

you need a return statement. At the end of the method, you need to use the "return" keyword followed by the String object (or whatever return type your method has). Remember to put this after all necessary code is run.

The reason this wasn't a problem before is that a void method does not return anything, so a return statement is not explicitly needed. However, if there is a returned parameter, you must explicitly state what you want to return.

example:

String foo() { return new String("bar"); }

[Torgero]

Ok, I finally made that work. I got this problem and that is how to withdraw money from a account and if the withdraw exceds the money in the account plus 1000 NOK then, you wont be able withdraw.. This is I got so far...

public double uttak(double beløp) {

if (saldo < 0) // withdraw value is negative
{

System.out.println ("Du har ikke nok penger på konto..");

}
else
if (beløp > saldo) // withdraw value exceeds balance
{

System.out.println ("Du har ikke nok penger på konto..");

}
else
saldo = saldo - beløp;

return saldo;

[Norm]

I got this problem

Can you explain it some more?
What is the uttak method supposed to do?
Your if/else code tests for 3 conditions. For one it returns a value.
What is it supposed to do for the other 2 conditions?

[Torgero]

Uttak is the same as withdraw money..

1. If you have enough money in the account you can withdraw that.

2. If you have 1 or more you can withdraw 1 + the credit limit which is 1000.. AKA 1001..

3. If you have - (minus) on the account you cant withdraw at all.

[Norm]

What is the uttak method supposed to do or return for each of the three cases?
It must either return an amount or throw an exception. It's up to the programmer to decide which and then to code it in his program.
What makes sense for the method to do if there is not enough money?

[Torgero]

How can I make this program loop, so that I can withdraw and increase money a lot of times...?

import static javax.swing.JOptionPane.*;


class Konto {
private long kontonr;
private String navn;
private double saldo;

public Konto(long startKontonr, String startNavn, double startSaldo) {
kontonr = startKontonr;
navn = startNavn;
saldo = startSaldo;
}

public String toString() {
return "Kontonr.: " + kontonr + "\nNavn: " + navn + "\nSaldo: " + saldo;
}

public long finnKontonr() {
return kontonr;
}

public String finnNavn() {
return navn;
}

public double finnSaldo() {
return saldo;
}

public double innskudd(double beløp) {
saldo = saldo + beløp;
return saldo;


}

public double uttak(double beløp) {

if (beløp > saldo) // withdraw value exceeds balance
{

System.out.println ("Du har ikke nok penger på konto til uttak..");
return saldo;

}
else
saldo = saldo - beløp;
return saldo;
}

}

class KontoTest {
public static void main(String[] args) {


Konto olesKonto = new Konto(123456676756L, "Ole Olsen", 1000);


long kontonr = olesKonto.finnKontonr();
String navn = olesKonto.finnNavn();
double saldo = olesKonto.finnSaldo();

System.out.println("Før endring av dataene: \nKontonr: " + kontonr +
", navn: " + navn + ", saldo: " + saldo);

String tekst = showInputDialog("Hvor mye settes inn:");
double beløp = Double.parseDouble(tekst);
showMessageDialog(null, "Du har nå " + olesKonto.innskudd(beløp) + " NOK disponibelt på konto.");

String tekst1 = showInputDialog("Hvor mye taes ut:");
double beløp1 = Double.parseDouble(tekst1);
showMessageDialog(null, "Du har nå " + olesKonto.uttak(beløp1) + " NOK disponibelt på konto.");




System.out.println(olesKonto.toString());
}
}

[ojn]

Look up while and how that works.

[Torgero]

Ok, cheers...