TCP socket - chat server

[Gatsu]

Hi, so im attempting to make a chat server that stores incoming connections in an ArrayList so that we can send chat messages to all those clients when receiving a string.

Here in this server I just add the connecting sockets to a list and loops trough them for every incoming message so that all clients can recieve it. Would this work well?

    /**
     * handle i/o from the clients
     */
    private boolean handleClientRequest(Socket clientHandlerSocket) throws IOException
    {
        userList(clientHandlerSocket);
        
        for(int i = 0 ; i < mConnected.size() ; i++)
        {
            currentSocket = mConnected.get(i);
            
            DataOutputStream out = new DataOutputStream(currentSocket.getOutputStream()); //output stream
            BufferedReader in = new BufferedReader(new InputStreamReader(currentSocket.getInputStream())); //input stream
            
            mInText = in.readLine();
            
            if(mInText.startsWith("QUIT"))
            {
                mRun = false;
            }
            else
            {
                if(currentSocket.isConnected() == true) //check if socket is still connected
                {
                    out.writeBytes(mInText);
                }
                else //remove a socket from the ArrayList of connected sockets
                {
                    System.out.println("Removed disconnected socket: " + mConnected.get(i));
                    mConnected.remove(i);
                    i -= 1;
                }
            }
            
            //close streams
            out.flush();
            out.close();
            in.close();
        }
        
        return mRun;
    }
    
    /**
     * list all connected users
     */
    private void userList(Socket clientHandlerSocket)
    {
        if(!mConnected.contains(clientHandlerSocket))
        {
            mConnected.add(clientHandlerSocket);
            System.out.println("socket added: " + clientHandlerSocket);
        }
    }

[DarrylBurke]

Moved from New to Java

db