[SOLVED] Downloading source code of specified URL

[sureshkumarcs88]

Hi everybody,

I'm trying to download a web page.But the problem is, the downloaded code contains repetition of some part of the code after the end of file. Here is the program......

Anyone please help me to solve this issue......

public void download(String source, String destination) throws MalformedURLException,IOException
{
BufferedInputStream in = new BufferedInputStream(new java.net.URL(source).openStream());
FileOutputStream fos = new FileOutputStream(destination);
BufferedOutputStream bout = new BufferedOutputStream(fos,1024);

byte data[] = new byte[1024];

while(in.read(data)!=-1)
{
bout.write(data);
}

bout.close();
fos.close();
in.close();
}
}

[OrangeDog]

The last read is unlikely to fill the byte buffer, yet you write out the entire buffer including the end section which hasn't been overwritten. This is why InputStream.read() returns an integer; use it.

Also, fos.close() is unnecessary as bout.close() has already closed it.

[sureshkumarcs88]

Thanks for rly,

I couldn't get u correct. Can u tell me clearly?

[OrangeDog]

You have a buffer called data[].
You read bytes into this buffer.
Sometimes you won't fill this buffer.
This happens especially at the end of a stream.
When this happens, the end of the buffer still contains the old data.
You then write the old data to bout.
Using the return value from InputStream.read() will solve the problem.

[sureshkumarcs88]

Thank you very much.

I got it correct.