Problem with deleting record.

Hi guys I'm having trouble deleting a record from my database, I'm able to insert a record but can't delete any. This is my code for my delete button. Basically there supposed to put the number of the question into the text field and click the delete button then it takes the number the user has inputted and uses it in a query to delete it. I'm not 100% sure if this is how you do it so any help would be great.

String selquestion1 = selquesttxt.getText();
int selquestion = Integer.parseInt(selquestion1);

try
{


Connection con = DriverManager.getConnection(databaseURL, "user", "password");
Statement stmt = con.createStatement();


String sql = "DELETE * FROM APP.QUESTIONS WHERE QUESTIONS.QUESTIONNO = " + selquestion;
stmt.executeUpdate(sql);


JOptionPane.showMessageDialog(null, "Question number " + selquestion + "has been deleted from the database.");
}catch(SQLException e)
{
JOptionPane.showMessageDialog(null,e);
}

// DELETE QUESTION BUTTON
}

Have you run your SQL directly on the database to make sure it is correct?

Also, you should use a PreparedStatement instead.

Quote:

---

Originally Posted by javaguy345

but can't delete any.

---

So what is happening instead?
Which JOptionPane message is being displayed?
Is neither being displayed?

Error code -1, SQL state 42X01: Syntax error: Encountered "*" at line 1, column 8. This is the sql error I'm getting, I think it has something to do with the *.

The * is not valid sql in that delete statement.

I'm passing an Integer but it still says I'm passing a CHAR

Try this

String sql = "DELETE FROM APP.QUESTIONS WHERE QUESTIONS.QUESTIONNO = '"+selquestion+"'";

Use a PreparedStatement, not a Statement, then use the correct setXXXX() method for the data type that column QUESTIONNO has.
Then, if you still have errors, post the error and full stack trace here.
Don't try and interpret the error...copy and paste it.

it is more appropriate to use PreparedStatement than concatenated strings.
Here is a tutorial from java about PreparedStatement Using Prepared Statements (The Java™ Tutorials > JDBC(TM) Database Access > JDBC Basics)
And here is a example of using it PreparedStatement delete,JDBC Delete,Deleting Records using the Prepared Statement

Do you think after three of us mentions PSs that it might sink in?
:)

ETA: Though I will say that generally Rose India is a poor choice of site for examples.
In the one you posted the connection is not closed in a finally block, for example. Something that is a frequent cause of bugs.

@Tolls - Did not see your reply, probably my browser.
@OP - use code tags when posting codes.

What is the advantage of using a prepared statement I got it working without it so what would be the reason.

Quote:

---

Originally Posted by hitesh

Try this

String sql = "DELETE FROM APP.QUESTIONS WHERE QUESTIONS.QUESTIONNO = '"+selquestion+"'";

---

Why?

kind regards,

Jos

Quote:

---

Originally Posted by javaguy345

What is the advantage of using a prepared statement I got it working without it so what would be the reason.

---

That's why.

kind regards,

Jos

Getting it to work and getting it to work properly are not the same thing.
Anytime you are applying variables (with a few minor exceptions) to a query you should use a PreparedStatement.
Jos has given one reason (SQL injection), but there are others. Like less overhead on the db server for starters.
Oh, and not having to faff with escaping in Strings.

hi guys
try this code and useful to you...
and check your database url name

String sql = "DELETE * FROM APP.QUESTIONS WHERE QUESTIONS.QUESTIONNO = " + selquestion+"";
PreparedStatement ps=con.PrepareStatement(query);
ps.executeUpdate();


JOptionPane.showMessageDialog(null, "Question number " + selquestion + "has been deleted from the database.");
}catch(SQLException e)
{
JOptionPane.showMessageDialog(null,e);
}

Oh right.
So you prepare a statement but don't actually use the PS the way it should be.
Indeed, all you've done is change Statement to PreparedStatement...pointless.

If you don't know how to use these things then don't you think it might be an idea not to respond?

Quote:

---

Originally Posted by B.vijayanand

hi guys
try this code and useful to you...

---

As an example of absolute crap it is. Why do people who don't know zilch about the subject open their mouth and spread all this rubbish around?

Jos

Quote:

---

Originally Posted by javaguy345

What is the advantage of using a prepared statement I got it working without it so what would be the reason.

---

I am not good in english so I may not explain it well to you. Here are some links that explain usage of preparedStatements
Easy String Concatenation Considered Harmful? | Java.net
MySQL :: Prepared Statements