SQL Update with ? as values

[Mikey]

Hi, I am trying to get the password collumn in my database to update with a new password from which the user will enter into a Java GUI. The Java side is working fine, however my SQL is complaining saying that 'ERROR: null value in column "password" violates not-null constraint'. Even though I am actually specifying a value. Here is the UPDATE statement:

public static void updatePassword(String password, int userID) {

Connection connection = connectionDB.createConnection();
try {
PreparedStatement stmt = connection.prepareStatement("UPDATE login "
+ "SET password = ?"
+ "WHERE login_id = ?");

stmt.setString(1, password);
stmt.setInt(2,userID);
stmt.execute();


} catch (Exception e) {
System.out.println(e.getMessage());
}
System.out.println("Password" +password);
System.out.println("UserID"+ userID); // It is finding the correct userID but not updating the password for that user!
}

If anyone can help, thats great :)

[UJJAL DHAR]

Replace this

PreparedStatement stmt = connection.prepareStatement("UPDATE login "
+ "SET password = ?"
+ "WHERE login_id = ?");

stmt.setString(1, password);
stmt.setInt(2,userID);
stmt.execute();

by

PreparedStatement stmt = connection.prepareStatement("UPDATE login SET password = ' +"password"+ ' WHERE login_id = ' +"userID"+ ');
stmt.execute();

[DarrylBurke]

Replace this

PreparedStatement stmt = connection.prepareStatement("UPDATE login "
+ "SET password = ?"
+ "WHERE login_id = ?");

stmt.setString(1, password);
stmt.setInt(2,userID);
stmt.execute();

by

PreparedStatement stmt = connection.prepareStatement("UPDATE login SET password = ' +"password"+ ' WHERE login_id = ' +"userID"+ ');
stmt.execute();

No, don't. That's susceptible to SQL injection.

db

[UJJAL DHAR]

No, don't. That's susceptible to SQL injection.

db

It will work.Then what is the problem? Can you explain?
And please give the solution.

[Mikey]

If thats subject to SQL Injection then I can't really use it. Thanks for the suggestion though. Any other idea's? Thanks

[Fubarable]

It will work.Then what is the problem? Can you explain?
And please give the solution.

Are you familiar with the SQL injection issue? If not, you should understand it first before giving SQL advice, and you can find all about it on Google and in fact in Wikipedia.