Calling Stored Procedures from oragle10g

[chizbox]

please help me with my code i cant seem to run it from java
i have google sample codes and try using it but it dosnt work

String sql = "call pckg_insert_event.trakout('" + lt.getLotClass() + lt.getLotNo() +"','"+lt.getDevice()+"',"+ lt.getWaferQty() + "," + lt.getShipQty() + ",'"+ lt.getInvoiceNo() + "')";

CallableStatement cStmt = conn.prepareCall(sql);


The SQL statement is this
call pckg_insert_event.trakout('AJ1234567890','ORMIC-012',2,2008,'1234567890')

[travishein]

I think the sql statement needs to be enclosed in "{" and "}". Its some kind of JDBC escape notation.

as,

String sql = "{ call pckg_insert_event.trakout('" + lt.getLotClass() + lt.getLotNo() +"','"+lt.getDevice()+"',"+ lt.getWaferQty() + "," + lt.getShipQty() + ",'"+ lt.getInvoiceNo() + "') }";

Though, CallableStatement extends PreparedStatement. I think its better to make use of positional parameters where possible, to avoid problems if the string variable values contain single quotes and needing to escape these, or to prevent sql injection attacks, if it is ever possible one of these string values could be entered from an end user form input field.

String sql = "{ call pckg_insert_event.trakout(?, ?, ?, ?, ?) }";

CallableStatement cStmt = conn.prepareCall(sql);
cStmt.setString(1, lt.getLotClass() + lt.getLotNo() );
cStmt.setString(2, lt.getDevice());
cStmt.setInt     (3, lt.getWaferQty());
cStmt.setInt     (4, lt.getShipQty());
cStmt.setString(5, lt.getInvoiceNo());

cStmt.execute();

[chizbox]

Thanks bro it really helped me!