Downloading a file thro Struts via response OutputStreaming

Hello there. Im making a application to download files. The problem im having is: Some files like PDF or DOC are downloaded correctly, but a .exe or a .dat or .txt are nawt. Im not really sure why is this happening, ive tryed many things. Heres the download part witch i belive is wrong somehow.

Code:

---

public void download(int indice) throws Throwable { 
 
        if(!validate()) throw new Exception("No response !"); 
 
        response.setContentType("application/octet-stream");         
        String path = getDownloader().getDir() + getDownloader().getListaArquivos().get(indice); // example "C:/folder/file.txt" 
         
        File file = new File(path); 
        FileInputStream fileIn = new FileInputStream(file); 
        ServletOutputStream out = response.getOutputStream(); 
         
        byte[] outputByte = new byte[2*4096]; 
         
        while(fileIn.read(outputByte, 0, 2*4096) != -1) { 
            out.write(outputByte, 0, 2*4096); 
        } 
        fileIn.close(); 
        out.flush(); 
        out.close(); 
    }

---

Ive tryed to add this following line:

response.setHeader("Content-disposition", "attachment;"); , it does not work as well. If i add this in the begining of the page, it makes me download the .JSP, if i make this inside download method, it does nothing.

Does anyone knows how to solve this ?

Thanx for any responses.

[]´s Ziden

Code:

---

out.write(outputByte, 0, 2*4096);

---

You are writing out 8k everytime...even if the read did not read in 8k. Which would be the likely case at the end of a document.

You'll need to get the byte count from the read() call and use that.

How could i count the bytes im reading ?

I could make this work making this:

Code:

---

  public void download(int indice,  HttpServletResponse resp) throws Throwable {
              resp.addHeader("Content-Disposition","Attachment;Filename="+getDownloader().getListaArquivos().get(indice));
              String caminho = getDownloader().getDir() + getDownloader().getListaArquivos().get(indice);
        File file = new File(caminho);
        FileInputStream fileIn = new FileInputStream(file);
        ServletOutputStream out = resp.getOutputStream();
       
        byte[] outputByte = new byte[2*4096];

        while(fileIn.read(outputByte, 0, 2*4096) != -1) {
            out.write(outputByte, 0, 2*4096);
        }
       
        // THIS IS BAD
        fileIn.close();
        out.flush();
        out.close();
       
    }

---

The thing is, the THIS IS BAD comment is only runned after the user accepts the download, IF it does. In cases the user dont accept the download, the program gets locked for a few seconds and if i try to download another file thro that, it gets me a socket write error.

Thanx for your help.

[]´s Ziden

Code:

---

fileIn.read(outputByte, 0, 2*4096)

---

returns an int...that is the number of bytes read (or -1 if you've read everything).
So assign that value to an int.

Code:

---

int bytecount = 0;
while((bytecount  = fileIn.read(outputByte, 0, 2*4096)) != -1) {
etc etc

---

Oh i see... i got that right but still dont know about the guys 'refusing' download, since the past-while code only executes if the user ACCEPTS the download

is there somehow to make downloads not acceptables ? Making they start w/ no Save/Open etc ? U click, download start.