Null pointer exception

[samuel.roshni]

My jdbc code is as follows

public ArrayList<IncentiveBean> displayIncentive(int empNo, int year) {
		ArrayList<IncentiveBean> ilist = new ArrayList<IncentiveBean>();
		try {
			
			makeConnection();
			
			pst = conn
					.prepareStatement("SELECT p.project_id,p.project_name,e.proj_incentive FROM employee_project e, project_master p WHERE p.project_id=e.project_id AND emp_id=? AND e.allocation_date<TO_DATE(?) AND e.release_date>TO_DATE(?)");
			pst.setInt(1, empNo);
			pst.setString(2, "31-Mar-" + year);
			pst.setString(3, "1-Apr-" +(year - 1));
			
			ResultSet rs = pst.executeQuery();
			
			while (rs.next()) {
				
				IncentiveBean inc = new IncentiveBean();
				inc.setProjId(rs.getString(1));
				inc.setProjName(rs.getString(2));
				inc.setProjIncentive(rs.getDouble(3));
				ilist.add(inc);
			}
			releaseConnection();
			
		} catch (SQLException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
			releaseConnection();
		} 
		return ilist;
	}

The connection is gettin created.. put it givea me a null pointer exception at releaseConnection()..

The exception occurs at times.. otherwise the code executes successfully.. i am not settin any null value to the variables
Please help..

[Eranga]

Please use code tags next time, when you are posting code segments in the forum. Unformated codes are really hard to read.

[Eranga]

And also please provide more details about the question, like complete error message, and the relevant codes like releaseConnection() implementation and so on. Otherwise it's bit difficult to comment on your question.

[RamyaSivakanth]

There are lot of chances ur code will end up in problem.
1. Inside resultset loop,if no proper data is there then setter will have trouble.

2. why you have 2 release connection method here? Place the connection in finally block.
so whether the exception occurs or not occurs finally will be executed once.

3. check if the connection = null or not before calling release connection.

Put s.o.p for debugging.

As Eranga suggested,format the code.

[Eranga]

There are lot of chances ur code will end up in problem.
1. Inside resultset loop,if no proper data is there then setter will have trouble.

2. why you have 2 release connection method here? Place the connection in finally block.
so whether the exception occurs or not occurs finally will be executed once.

3. check if the connection = null or not before calling release connection.

Oh yes, a lot. Small change can make a big difference, like the query not return data at all. Validations are tricky at that point.

[Tolls]

I suspect (as Ramya points out) that it's the two releaseConnection calls.
Just have the one, in a finally block. That should do you.
Also, as Eranga asks, what does the code in releaseConnection() look like?
Do you check whether the conn is already null or not before trying to close it?

[Tolls]

There are lot of chances ur code will end up in problem.
1. Inside resultset loop,if no proper data is there then setter will have trouble.

The rest is good advice, but I'm not sure I understand what you're saying here?

[Eranga]

I think it's about manipulating dataset in a while loop.

[RamyaSivakanth]

ya exactly Eranga as you said .
If the record has null values ,then setter may end up in trouble.

[Tolls]

Why?
This is a perfectly normal way of populating a List from a result set.
You loop round the result set, creating an instance for each row, populating the values based on the getXXX() from the result set. Then add that instance to the List.

Or am I missing something in this instance?

[RamyaSivakanth]

Instantiating the object and adding to the list is perfectly right.

what iam saying here is about return type of resultset and setting it inside setter method.

Error occurence is very less ( as Tolls suggested). But, for code improvement I have given a tip.

[Eranga]

For me there is no error (however some are confusing), but it leads to empty list. If the list traverse in random sequence after that in a different case...

[RamyaSivakanth]

Ok fine .Come up with complete formatted code with s.o.p and proper comments.

[Tolls]

Instantiating the object and adding to the list is perfectly right.

what iam saying here is about return type of resultset and setting it inside setter method.

Error occurence is very less ( as Tolls suggested). But, for code improvement I have given a tip.

Ah. I hadn't noticed one of the columns is a double.
You're saying if column 3 is null then the call to getDouble() will give us 0, which may not be correct?
I have to say I never did understand why those weren't defined as returning Double or Integer, rather than primitives.

Then again, I always use getBigDecimal and getBigInteger.

[Fubarable]

Hijack post deleted. Poster, if you have a question, please ask it in a new thread. Locking thread.