my code works fine but don't know if its the right way

Printable View