Moving a ball with Arrow Keys

[kekcklemen]

Ok guys. I'm making a game. For now I made a program in which you can move ball with arrow keys. UP, DOWN, RIGHT and LEFT.

My first question is:
I clicked one button... Ball moves... but not instantly!! I just hate this. Like it's somehow delayed or something. At key click it moves only for 5 sources than it moves normally. But I want that ball moves constantly... Try it out with my code. How to make ball moving nice and without dalaying?

My second question is:
I can move left and right, up and down. :D how to move up and left at the same time? when I click Up and Left keys I want that ball moves up and left. not just left or just up. how to do that?

here is the code:

import java.awt.Canvas;
import java.awt.Dimension;
import java.awt.Graphics2D;
import java.awt.image.BufferStrategy;
import java.awt.event.*;
import javax.swing.*;

public class HandlingEvents implements Runnable {

    JFrame frame;
    int myX = 400;
    int myY = 400;
    Canvas canvas;
    BufferStrategy bufferStrategy;
    boolean running = true;

    public HandlingEvents() {
        frame = new JFrame("Basic Game");
        JPanel panel = (JPanel) frame.getContentPane();
        panel.setPreferredSize(new Dimension(500, 500));
        panel.setLayout(null);
        canvas = new Canvas();
        canvas.setBounds(0, 0, 500, 500);
        canvas.setIgnoreRepaint(true);
        panel.add(canvas);
        canvas.addKeyListener(new KeyAdapter() {
            @Override
            public void keyPressed(KeyEvent evt) {
                moveIt(evt);
            }
        });
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.pack();
        frame.setResizable(false);
        frame.setVisible(true);
        canvas.createBufferStrategy(2);
        bufferStrategy = canvas.getBufferStrategy();
        canvas.requestFocus();
    }
    public void run() {
        while (running = true) {
            Paint();
            try {
                Thread.sleep(25);
            } catch (InterruptedException e) {
            }
        }
    }
    public static void main(String[] args) {
        HandlingEvents ex = new HandlingEvents();
        new Thread(ex).start();
    }
    public void Paint() {
        Graphics2D g = (Graphics2D) bufferStrategy.getDrawGraphics();
        g.clearRect(0, 0, 500, 500);
        Paint(g);
        bufferStrategy.show();
    }

    protected void Paint(Graphics2D g) {
        g.fillOval(myX, myY, 30, 30);
    }
    public void moveIt(KeyEvent evt) {
     switch (evt.getKeyCode()) {
            case KeyEvent.VK_DOWN:
                myY += 5;
                break;
            case KeyEvent.VK_UP:
                myY -= 5;
                break;
            case KeyEvent.VK_LEFT:
                myX -= 5;
                break;
            case KeyEvent.VK_RIGHT:
                myX += 5;
                break;
        }
        
      
        
    }
}

[NRitH]

I just compiled and ran your code as-is, and I see no delay in moving the ball after I've clicked. I also see it moving diagonally when I press two adjacent arrow keys at once.

[kekcklemen]

I just compiled and ran your code as-is, and I see no delay in moving the ball after I've clicked. I also see it moving diagonally when I press two adjacent arrow keys at once.

=/ lol
I'm using netbeans.. Which program do you use?

[NRitH]

While I'm at it, here are some tips:

1. Get rid of all that BufferStrategy nonsense. It works, but it's overkill.
2. Remove the "implements Runnable" and the new Thread crap in main().
3. Make your class extend Canvas.
3. Override your Canvas's paint() method to do the clearing and drawing that are in your miscapitalized Paint() methods.
4. Remove the call to setIgnoreRepaint().
5. You don't need a Graphics2D object; just use a java.awt.Graphics one.
6. At the end of your keyPressed() method, call repaint().

The result? Much, much clearer code. To wit:

import java.awt.*;
import java.awt.event.*;
import javax.swing.JFrame;

public class HandlingEvents extends Canvas {

    int myX = 400;
    int myY = 400;

    public HandlingEvents() {
        setSize(new Dimension(500, 500));
        addKeyListener(new KeyAdapter() {
            @Override
            public void keyPressed(KeyEvent evt) {
                moveIt(evt);
            }
        });
    }

    public void paint(Graphics g) {
        g.fillOval(myX, myY, 30, 30);
    }

    public void moveIt(KeyEvent evt) {
     switch (evt.getKeyCode()) {
            case KeyEvent.VK_DOWN:
                myY += 5;
                break;
            case KeyEvent.VK_UP:
                myY -= 5;
                break;
            case KeyEvent.VK_LEFT:
                myX -= 5;
                break;
            case KeyEvent.VK_RIGHT:
                myX += 5;
                break;
        }

        repaint();
    }

    public static void main(String[] args) {
        JFrame frame = new JFrame("Basic Game");
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        HandlingEvents ex = new HandlingEvents();
        frame.getContentPane().add(ex);
        frame.pack();
        frame.setResizable(false);
        frame.setVisible(true);
        ex.requestFocus();
    }
}

[Fubarable]

While I'm at it, here are some tips:
...
3. Make your class extend Canvas.
3. Override your Canvas's paint() method to do the clearing and drawing that are in your miscapitalized Paint() methods.
....

Since this is a Swing program, I would recommend that the drawing panel extend JPanel and that the drawing occur in the paintComponent method.

[NRitH]

Since this is a Swing program, I would recommend that the drawing panel extend JPanel and that the drawing occur in the paintComponent method.

Damn, that's an excellent point.