need help in this code

**diwakardelhi** · 11-07-2009, 04:40 AM

guys i m new to programming world nd to java...please help me in this simple code. i m trying to find the largest number from the array of numbers from user.i m using eclipse.
the error that i get is
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 5
at max.main(max.java:12)
:confused:

import java.util.Scanner;
public class max {
public static void main(String[] args){
int ar[]= new int [5];
Scanner input = new Scanner(System.in);
System.out.println("Please enter 5 numbers.");
for(int count=0; count<5;count++){
ar[count]= input.nextInt();
}
int second=1,max=ar[0];
for(int counter=0; counter<=4;counter++){
if(max<ar[second]) max=ar[second];
second++;
}
System.out.println("The biggest number of the 5 numbers is " + max);
}
}

**diwakardelhi** · 11-07-2009, 05:40 AM

guys i was able to solve the problem by changing the array 'ar' length to 7 in 4th line. i.e int ar[]= new int[7];
it worked fine. but it was just hit nd trial method that helped me. this code was not even working with array length 6also. i m still confused why do we have to take an array of 7 length to find maximum of 5 numbers??????
plss help...:confused:

**miq.system** · 11-07-2009, 07:56 AM

Java Code:

int second=1,max=ar[0];
for(int counter=0; counter<=4;counter++){
if(max<ar[second]) max=ar[second];
second++;

change counter<=4; become counter<4;

**CodesAway** · 11-07-2009, 08:17 AM

A recommendation, don't use numbers (e.g. 4) if you are iterating an array. Instead, use array.length or array.length - <some value>. This allows your code to be reused (for different size arrays).

Additionally, Seeing "for(int count=0; count<5;count++){" is confusing because it begs the question "where did the 5 come from?". Whereas, "for(int count=0; count<ar.length;count++){" is very clear, it means you want to do something for each value in the array.