Graphics2D repaint bug

[NextEpisode1]

Hy , i have a class that extends JLabel , with the feature of changing the text angle:

public class AngledJLable extends JLabel {
private static final long serialVersionUID = 1L;
private Integer angle;

public AngledJLable(String text , Integer angle, Color color ,Font font) {
super(text);
this.angle = angle;
setFont(font);
setForeground(color);
setBackground(new Color(0,0,0,100));
}

protected void paintComponent(Graphics g) {
Graphics2D g2 = (Graphics2D)g;
g2.setRenderingHint(RenderingHints.KEY_ANTIALIASIN G,RenderingHints.VALUE_ANTIALIAS_OFF);
AffineTransform aT = g2.getTransform();
Shape oldshape = g2.getClip();
double x = getWidth()/2.0;
double y = getHeight()/2.0;
aT.rotate(Math.toRadians(angle), x, y);
g2.setTransform(aT);
g2.setClip(oldshape);
super.paintComponent(g);
}
}

but it seems each time it gets redrawn the previous text is not cleared. I have tried setting the text to "" but it seems not to work.
If any1 is willing to tell me what am i missing , i would appreciate it.
Cheers

[Fubarable]

Hy , i have a class that extends JLabel , with the feature of changing the text angle:

public class AngledJLable extends JLabel {
	private static final long serialVersionUID = 1L;
	private Integer angle;
	
	public AngledJLable(String text , Integer angle, Color color ,Font font) {
		super(text);
		this.angle = angle;
		setFont(font);
		setForeground(color);
		setBackground(new Color(0,0,0,100));
	}

	protected void paintComponent(Graphics g) {
        Graphics2D g2 = (Graphics2D)g;
        g2.setRenderingHint(RenderingHints.KEY_ANTIALIASING,RenderingHints.VALUE_ANTIALIAS_OFF);
        AffineTransform aT = g2.getTransform();
        Shape oldshape = g2.getClip();
        double x = getWidth()/2.0;
        double y = getHeight()/2.0;
        aT.rotate(Math.toRadians(angle), x, y);
        g2.setTransform(aT);
        g2.setClip(oldshape);
        super.paintComponent(g);
    }	
}

but it seems each time it gets redrawn the previous text is not cleared. I have tried setting the text to "" but it seems not to work.
If any1 is willing to tell me what am i missing , i would appreciate it.
Cheers

There's a bug alright. You need to call the super's paintComponent method as the first line of your override method.

[NextEpisode1]

There's a bug alright. You need to call the super's paintComponent method as the first line of your override method.

nope , if i call the super's paint component as the first line i loose the rotation effect desired.

[Fubarable]

nope , if i call the super's paint component as the first line i loose the rotation effect desired.

Then you're doing your rotation wrong as you need to call super first. I cannot compile anything right now, but perhaps you need to reset your AT back to its original state or do your drawing in a copy of the Graphics object. But seriously regardless of what needs to be done, super.paintComponent(g) should come first.

[NextEpisode1]

Then you're doing your rotation wrong as you need to call super first. I cannot compile anything right now, but perhaps you need to reset your AT back to its original state or do your drawing in a copy of the Graphics object. But seriously regardless of what needs to be done, super.paintComponent(g) should come first.

well im still a noobie in rich clients , and this code is pretty much copied from a forum :D (damn that hurts) . It seems i have managed to fix the issue by repainting the whole window (pretty expensive operation i might say).

Regarding the super first thing, why do you think i must call super.paintComponent(Graphics g) first? As i said be4 i dont have a rich experience in java graphics but common sense dictates : rotate it then show to the user.

[Fubarable]

Regarding the super first thing, why do you think i must call super.paintComponent(Graphics g) first? As i said be4 i dont have a rich experience in java graphics but common sense dictates : rotate it then show to the user.

That's not what the super method does -- it doesn't "show it to the user". Rather it clears the panel of the previous image, and the symptom of not calling it first is just what you describe.

[NextEpisode1]

That's not what the super method does -- it doesn't "show it to the user". Rather it clears the panel of the previous image, and the symptom of not calling it first is just what you describe.

You are right it's a good practice , but besides clearing the panel it also draws the text, if you notice i have no drawString() there , i let the JFrames paintComponent() do the drawing.

[doWhile]

Here's a tip: become extremely familiar with the API's of the classes you are using. Case in point (and something Fubarable alluded to): the setTransform method in graphics. Quote from Graphics2D (Java Platform SE 6)

WARNING: This method should never be used to apply a new coordinate transform on top of an existing transform because the Graphics2D might already have a transform that is needed for other purposes, such as rendering Swing components or applying a scaling transformation to adjust for the resolution of a printer.

In the link above you will find more explanation and alternatives to using this method

[NextEpisode1]

Here's a tip: become extremely familiar with the API's of the classes you are using. Case in point (and something Fubarable alluded to): the setTransform method in graphics. Quote from Graphics2D (Java Platform SE 6)


In the link above you will find more explanation and alternatives to using this method

This is getting more and more interesting as we go :)) thanks , i'l read some documentation now :P

[toadaly]

I've found that when one of the canned swing components doesn't do what you want out of the box, it's usually easier to create your own custom component by extending JComponent than to extend an existing component. But if you really want to extend JLabel, you can manually clear the canvas yourself by simply calling

Rectangle r = getBounds();
g.clearRect(r.x, r.y, r.width, r.height);

...this is actually sloppy, as you should take the insets into account as well. This certainly isn't a Graphics2D bug though. There is nothing in the API that states it will automatically clear the canvas for you.

[NextEpisode1]

I've found that when one of the canned swing components doesn't do what you want out of the box, it's usually easier to create your own custom component by extending JComponent than to extend an existing component. But if you really want to extend JLabel, you can manually clear the canvas yourself by simply calling

Rectangle r = getBounds();
g.clearRect(r.x, r.y, r.width, r.height);

...this is actually sloppy, as you should take the insets into account as well. This certainly isn't a Graphics2D bug though. There is nothing in the API that states it will automatically clear the canvas for you.

The bug is in my code not in graphics class , i was ambiguous with the post name , sry . And with the clearRect() , been there tried that. I have this label on a transparent window , so i cant clear it directly from the class.

I have found a pretty decent workaround : i added the lbl to a panel and repaint that panel