Double drawing problem with 2D

Hi, my code works fine all I wanted to ask is my codes prints double of same triangles like it should draw 10 random triangles and it draws 10 random triangles then again it wipes of the screen and draw again 10 random triangles so all I want is 10 not 20 so any inputs will be really helpful thanks.

Code:

---


import java.awt.*;
import java.awt.event.*;
import java.awt.geom.*;
import javax.swing.*;

public class Triangles2 extends JFrame
        {


                public Triangles2()
                {
                        super( "Random Triangles" );
                        getContentPane().setBackground( Color.black );
                        setSize( 400, 600 );
                        setVisible( true );
                }



                public void paint( Graphics g )
                {
                        super.paint( g );


                        int xP, yP, zP;



                        Graphics2D g2d = ( Graphics2D ) g;


                        for( int count = 1; count <= 10; count++ )
                        {
               

                        GeneralPath triangle = new GeneralPath();

                        xP = ( int ) ( Math.random() * 256 );
                        yP = ( int ) ( Math.random() * 256 );
                        zP = ( int ) ( Math.random() * 256 );

                        try
                        {
                                Thread.sleep(700);
                        }
                                catch (Exception e) {}


                        triangle.moveTo( ( int ) ( Math.random() * 400 ), ( int ) ( Math.random() * 400 ) );

                        triangle.lineTo( ( int ) ( Math.random() * 400 ), ( int ) ( Math.random() * 400 ) );

                        triangle.lineTo( ( int ) ( Math.random() * 400 ), ( int ) ( Math.random() * 400 ) );

                        triangle.closePath();


                        g2d.setColor( new Color( xP, yP, zP ) );


                        g2d.fill( triangle );

                        }

                }



                public static void main( String args[] )
                {

                        Triangles2 myTriangles = new Triangles2();
                        myTriangles.setDefaultCloseOperation( JFrame.EXIT_ON_CLOSE );
                }
        }//class

---

Quote:

---

Originally Posted by leapinlizard

Hi, my code works fine

---

I'm afraid that I'm going to have to disagree here as you are violating several rules of Swing graphics, and the reason for your error is due to these problems:

1) You should not draw directly in the JFrame but instead should draw in a JPanel or JComponent and then add this to the JFrame.

2) You should not paint in a paint method override but rather in a JPanel or JComponent's paintComponent override.

3) Never, I repeat, NEVER, have a Thread.sleep(...) in a drawing routine. All this does is freezes the app.

To learn how to draw properly, please see the Sun graphics tutorials.

If this were my app, I'd do the following:

1) Create a Triangle class that accepts an array of x points and an int array of y points as well as a Color and that has a paint(Graphics g) method that allows it to paint itself.

2) Create a class that extends JPanel and overrides JPanel's paintComponent. The first method call inside the paintComponent override will be super.paintComponent(g).

3) Give this class a triangle list: ArrayList<Triangle>

4) In the paintComponent override, iterate through the list above calling paint on each of the triangles.

5) If I wanted to stagger the creation of the triangles, I'd use a Swing Timer that would add a new Triangle to the list and would increment an int counter (triangleCount), create a new triangle with random points and color, add it to the list and call repaint on the JPanel. If triangleCount >= MAX_TRIANGLE_COUNT, then the timer would stop.

Hi. I have a question (a dumb one). What is a JComponent? I looked through this page ( A Visual Guide to Swing Components (Java Look and Feel) (The Java™ Tutorials > Graphical User Interfaces > Swing Features) ) and couldn't find it.

Quote:

---

Originally Posted by Lil_Aziz1

Hi. I have a question (a dumb one). What is a JComponent? I looked through this page ( A Visual Guide to Swing Components (Java Look and Feel) (The Java™ Tutorials > Graphical User Interfaces > Swing Features) ) and couldn't find it.

---

Pretty much everything on that page is a JComponent as it's the class that underlies most Swing components. It's somewhat like a primative JPanel.