Database help... whats wrong?

[neosnokia]

Hi all,

I am trying to make an SQL statement which inserts values in to a database. So far, i have typed this in but it doesnt work and Netbeans gives a red error line underneath the line which reads ResultSet theResult=theStatement.executeQuery("INSERT INTO etc etc

    public void inserttoDb ()
    {
        try
        {
          //Directory may need to be changed for differnt computer
          Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
          String myDB = "jdbc:odbc:Driver={Microsoft Access Driver (*.mdb)};DBQ= F:/JDB/sicksys.mdb";
          theConnection = DriverManager.getConnection(myDB);
          Statement theStatement=theConnection.createStatement();
          ResultSet theResult=theStatement.executeQuery("INSERT INTO Table1 (list_1,DayOff,MonthOff,YearOff,DayBack,MonthBack,YearBack VALUES("+"'"+ list_1 +"'"+ DayOff +""+"'"+ MonthOff +""+"'"+ YearOff +""+"'"+ DayBack+""+"'"+ MonthBack +""+"'"+ YearBack +")));

        }

        catch(Exception e)
        {
            System.out.println(e.getMessage());
        }

Can anyone see anything majorly wrong with this?

[masijade]

Where are the commas separating these values?

+"'"+ list_1 +"'"+ DayOff +""+"'"

You should really use PreparedStatement and not cobble together statements like this. That will prevent a lot of these sorts of errors, as well as automatically correctly formatting values, and help to prevent SQL Injection attacks.

[vrk]

hey, in ur query u havnt properly closed the string literal........
executeQuery("Insert...........()"); tht's y it is givin u error.

[vrk]

by the way..u shudnt use executeQuery() for an insert stmt. so chnge it to executeUpdate() & chk again!

[venkatallu]

hey,u should not use executeQuery() for insert.U have to use executeUpdate().
And u didnt close brackets properly in Insert query.

The correct one is ,

executeUpdate("INSERT INTO Table1 (list_1,DayOff,MonthOff,YearOff,DayBack,MonthBack, YearBack) VALUES("+"'"+ list_1 +"'"+ DayOff +""+"'"+ MonthOff +""+"'"+ YearOff +""+"'"+ DayBack+""+"'"+ MonthBack +""+"'"+ YearBack +"));

Try the above one.