Whats wrong with this?

[Alkor]

Well no movement... but the keylistener is set up as far as i know.

package game;

import java.awt.*;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import javax.swing.*;
 
public class BallRacer extends JFrame implements KeyListener{
    
    static int PlayerX;
    static int PlayerY;
    
   public BallRacer(String title) {
      super(title);
   }
    
    @Override
    public void keyTyped(KeyEvent e) {}

    @Override
    public void keyPressed(KeyEvent e) {
        if(e.getKeyCode() == KeyEvent.VK_DOWN){
            PlayerY--;
        }
        if(e.getKeyChar() == KeyEvent.VK_RIGHT){
            PlayerX++;
        
        }
        if(e.getKeyChar() == KeyEvent.VK_DOWN){
            PlayerY++;
        }
        if(e.getKeyChar() == KeyEvent.VK_LEFT){
            PlayerX--;
        
        }
        if(e.getKeyChar() == KeyEvent.VK_ESCAPE){
            System.exit(0);
        
        }
    }
    
    @Override
    public void keyReleased(KeyEvent e) {}
   
    @Override
   public void paint(Graphics g) {
      super.paint(g);
      g.setColor(Color.blue);
      g.fillOval(PlayerX, PlayerY, 25, 25);
      g.setColor(Color.black);
      g.fill3DRect(0, 0, 800, 50, rootPaneCheckingEnabled);
      g.fill3DRect(0, 575, 800, 50, rootPaneCheckingEnabled);
      g.fill3DRect(0, 0, 50, 800, rootPaneCheckingEnabled);
      g.fill3DRect(750, 0, 50, 800, rootPaneCheckingEnabled);
    }
 
   private static void createAndShowGui() {
      JFrame MainFrame = new BallRacer("BallRacer v1");
      MainFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
      MainFrame.pack();
      MainFrame.setVisible(true);
      MainFrame.setResizable(false);
      MainFrame.setSize(800,600);
      
   }
   public static void main(String[] args) {
       
            while (PlayerY < 50) {
                PlayerY++;
            }
            while (PlayerY > 575) {
                PlayerY--;
            }
            while (PlayerX < 50) {
                PlayerX++;
            }
            while (PlayerX > 750) {
                PlayerX--;
            }
      SwingUtilities.invokeLater(new Runnable() {
            @Override
         public void run() {
            createAndShowGui();

            }
         }
      );
   }
}

[DarrylBurke]

Whats wrong with this?

It has a very poor subject line.

I don't see any code there that adds a KeyListener to a Component.

Also, I fail to see the point of the loops in the main(...) method that increment the badly named variables.

Moving to AWT/Swing

db

[Fubarable]

Well no movement... but the keylistener is set up as far as i know.

package game;

import java.awt.*;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import javax.swing.*;
 
public class BallRacer extends JFrame implements KeyListener{
    
    static int PlayerX;
    static int PlayerY;
    
   public BallRacer(String title) {
      super(title);
   }
    
    @Override
    public void keyTyped(KeyEvent e) {}

    @Override
    public void keyPressed(KeyEvent e) {
        if(e.getKeyCode() == KeyEvent.VK_DOWN){
            PlayerY--;
        }
        if(e.getKeyChar() == KeyEvent.VK_RIGHT){
            PlayerX++;
        
        }
        if(e.getKeyChar() == KeyEvent.VK_DOWN){
            PlayerY++;
        }
        if(e.getKeyChar() == KeyEvent.VK_LEFT){
            PlayerX--;
        
        }
        if(e.getKeyChar() == KeyEvent.VK_ESCAPE){
            System.exit(0);
        
        }
    }
    
    @Override
    public void keyReleased(KeyEvent e) {}
   
    @Override
   public void paint(Graphics g) {
      super.paint(g);
      g.setColor(Color.blue);
      g.fillOval(PlayerX, PlayerY, 25, 25);
      g.setColor(Color.black);
      g.fill3DRect(0, 0, 800, 50, rootPaneCheckingEnabled);
      g.fill3DRect(0, 575, 800, 50, rootPaneCheckingEnabled);
      g.fill3DRect(0, 0, 50, 800, rootPaneCheckingEnabled);
      g.fill3DRect(750, 0, 50, 800, rootPaneCheckingEnabled);
    }
 
   private static void createAndShowGui() {
      JFrame MainFrame = new BallRacer("BallRacer v1");
      MainFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
      MainFrame.pack();
      MainFrame.setVisible(true);
      MainFrame.setResizable(false);
      MainFrame.setSize(800,600);
      
   }
   public static void main(String[] args) {
       
            while (PlayerY < 50) {
                PlayerY++;
            }
            while (PlayerY > 575) {
                PlayerY--;
            }
            while (PlayerX < 50) {
                PlayerX++;
            }
            while (PlayerX > 750) {
                PlayerX--;
            }
      SwingUtilities.invokeLater(new Runnable() {
            @Override
         public void run() {
            createAndShowGui();

            }
         }
      );
   }
}

Given past posting history, QFP

[Alkor]

Could it be the static integers if it was, the while playerx and playery wouldn't work because for some reason it needs to be static any suggestions?

[Fubarable]

Could it be the static integers if it was, the while playerx and playery wouldn't work because for some reason it needs to be static any suggestions?

The variables shouldn't be static, but Darryl already told you one problem -- where do you add a KeyListener to anything? If you don't add a listener to a component then nothing gets listened to. I also recommend against using KeyListeners with Swing apps but instead using Key Bindings (check the tutorial on this).

[Borkpaladin]

Add the keylistener with 'mainFrame.addKeyListener(this);' and make sure you set 'mainFrame.setFocusable(true);'

[Fubarable]

Add the keylistener with 'mainFrame.addKeyListener(this);' and make sure you set 'mainFrame.setFocusable(true);'

And what happens once the user presses a JButton or enters a JTextField and the JFrame itself loses focus? Why are you recommending this when the much better recommendation to use key bindings, which solves all of these problems, has already been made?

[Borkpaladin]

And what happens once the user presses a JButton or enters a JTextField and the JFrame itself loses focus? Why are you recommending this when the much better recommendation to use key bindings, which solves all of these problems, has already been made?

Sorry, bit inexperienced with java, just trying to help.