Need help with assignment - JButton

hi there, can somebody help me fix my code? so my assignment is to write a GUI application that lets users select one of the two shapes and draw the shape. The user can select either a Circle, or a Triangle. After one of the shapes is selected, the user can draw it as follow: when Circle is selected, let the user draw a circle with two mouse clicks. The first one on the center and the second on a point on the periphery of the circle. when Triangle is selected, let the user draw a triangle with three mouse clicks. so in other to choose, my instructor wants us to use JButton.

My problem is in my JustViewer class = I can't make 2 buttons small and the other button is not displayed...

so here is my code
//circle

Code:

---

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.awt.geom.*;

public class CircleComponent extends JComponent
{
  public CircleComponent()
    {
        clicks = 0;
        MouseListener listener = new CircleListener();
        addMouseListener(listener);
        positionX = new int[2];
        positionY = new int[2];
    }

    public void paintComponent(Graphics g)
    {
            Graphics2D g2 = (Graphics2D) g;
            int postY = positionY[1] - positionY[0];
            int postX = positionX[1] - positionX[0];
            double diameter = 2 * (Math.sqrt((Math.pow(postX, 2)) - (Math.pow(postY, 2))));

            Ellipse2D.Double circle = new Ellipse2D.Double(positionX[0], positionY[0], diameter, diameter);
            g2.draw(circle);
    }

    class CircleListener implements MouseListener
    {
            public void mouseClicked(MouseEvent event)
            {
                    positionX[clicks] = event.getX();
                    positionY[clicks] = event.getY();
            clicks++;
            if(clicks % 2 ==0)
            {
                        repaint();
                clicks = 0;
            }
            }

                                    public void mouseReleased(MouseEvent event) {}
                                public void mousePressed(MouseEvent event) {}
                                public void mouseEntered(MouseEvent event) {}
                                public void mouseExited(MouseEvent event) {}
                            }

    private int[] positionX;
    private int[] positionY;
    private int clicks;
}

---

//triangle

Code:

---

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.awt.geom.*;

public class TriangleComponent extends JComponent
{
    public TriangleComponent()
    {
        clicks = 0;
        MouseListener listener = new MouseTriListener();
        addMouseListener(listener);
        positionX = new int[3];
        positionY = new int[3];
    }

    public void paintComponent(Graphics g)
    {
            Graphics2D g2 = (Graphics2D) g;
        Point2D.Double r1 = new Point2D.Double(positionX[0], positionY[0]);
        Point2D.Double r2 = new Point2D.Double(positionX[1], positionY[1]);
        Point2D.Double r3 = new Point2D.Double(positionX[2], positionY[2]);

        Line2D.Double post1 = new Line2D.Double(r1, r2);
        Line2D.Double post2 = new Line2D.Double(r2, r3);
        Line2D.Double post3 = new Line2D.Double(r3, r1);

        g2.draw(post1);
        g2.draw(post2);
        g2.draw(post3);
    }

        class MouseTriListener implements MouseListener
        {
            public void mousePressed (MouseEvent event)
            {
                positionX[clicks] = event.getX();
                positionY[clicks] = event.getY();
                clicks++;
                if (clicks % 3 ==0)
                {
                    repaint();
                    clicks = 0;
                }
            }

            public void mouseReleased(MouseEvent event) {}
            public void mouseClicked(MouseEvent event) {}
            public void mouseEntered(MouseEvent event) {}
            public void mouseExited(MouseEvent event) {}
        }

    private int[] positionX;
    private int[] positionY;
    private int clicks;
}

---

//the viewer

Code:

---

import java.awt.event.*;
import javax.swing.*;

public class JustViewer
{
  public static void main(String[] args)
  {
      final TriangleComponent component = new TriangleComponent();
      final CircleComponent component1 = new CircleComponent();

      final JFrame frame = new JFrame();

      JButton button = new JButton("Triangle");
      JButton button1 = new JButton("cirlce");
      frame.add(button);
              frame.add(button1);

  class TriangleListener implements ActionListener
  {
                  public void actionPerformed(ActionEvent e)
                  {
                          frame.add(component);
                  }
  }

  ActionListener listener = new TriangleListener();
  button.addActionListener(listener);

  class CircleListener implements ActionListener
  {
          public void actionPerformed(ActionEvent e)
          {
                  frame.add(component1);
          }
  }

  ActionListener listener1 = new CircleListener();
  button1.addActionListener(listener1);

  frame.setSize(300, 400);
  frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
  frame.setVisible(true);
        }
}

---

Thank you so much, I really appreciate it for reading

Quote:

---

My problem is in my JustViewer class = I can't make 2 buttons small and the other button is not displayed...

---

I only see 2 buttons in the JustViewer class. Where is the other button?

if you try to run the JustViewer class, you will see only circle button and it takes all the frame.

Create a JPanel, add both buttons to the JPanel and add that to the JFrame.

alrite I will try, thanks a lot Moderator :)

one more question, can I add JComponent stuffs to a panel? *for example add TriangleComponent class above to a panel, then add the panel to the frame? is it possible?

Why not try it and see what happens?

@Fubarable: I tried it and it doesnt work,however adding the buttons to the panel then add the panel to the frame works but I dont get the result I want, I have to expand the frame to the right to make the clicks and paint the triangle or circle

If you're having trouble, you'll need to show us your code attempts with explanation.

so based on TriangleComponent and CircleComponent class, I made JustViewer class to make the circle or triangle with 2 or 3 clicks.
as recommended by moderator Norm, I put the buttons into panel and add the panel to frame. so here is the updated code of JustViewer ( Triangle and Circle component are okay, at above)

Code:

---

import java.awt.event.*;
import javax.swing.*;

public class JustViewer
{
  public static void main(String[] args)
  {
      final TriangleComponent component = new TriangleComponent();
      final CircleComponent component1 = new CircleComponent();

      final JFrame frame = new JFrame();

      JButton button = new JButton("Triangle");
      JButton button1 = new JButton("cirlce");


  class TriangleListener implements ActionListener
  {
                  public void actionPerformed(ActionEvent e)
                  {
                          frame.add(component);
                  }
  }

  ActionListener listener = new TriangleListener();
  button.addActionListener(listener);

  class CircleListener implements ActionListener
  {
          public void actionPerformed(ActionEvent e)
          {
                  frame.add(component1);
          }
  }

  ActionListener listener1 = new CircleListener();
  button1.addActionListener(listener1);

  JPanel panel = new JPanel();
  panel.add(button);
  panel.add(button1);
  frame.add(panel);

  frame.setSize(300, 400);
  frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
  frame.setVisible(true);
        }
}

---

So my goal is, when I click one of the 2 buttons, I can make either the circle or triangle once. (e.g I click triangle button, I just click 3 times in the space given in the frame and then draw the triangle after that I can't make any triangle anymore. So next press the circle button to erase the triangle and just click twice in the same space to draw the circle).

But my problem now is, for example, when I pressed "Triangle" button, I can't make the triangle but instead I have to expand the frame to the right and make the clicks there. another problem is, then I pressed circle button (after the triangle button), I have to expand more the frame to the right to be able make the clicks and draw the circle. but at the same time, I also can draw the triangle.

Thank you for reading my problems. I really appreciate it.

Suggestions:

• Learn about layouts. For instance the JFrame contentPane (which is what you're adding components to when adding them to a JFrame) uses a BorderLayout, and you'll want to read the tutorial about BorderLayouts so you add components to the right spot. For instance the button panel should be added to the north position.
• Use debugging code to help you check the state of your program while it runs. For instance, it would be a good idea to check the size of your components when they are added to the GUI, and this can be done via System.out.println'ing the result of calling getSize() on your component.
• Use variable names that make sense and which make your code self-commenting. Which makes more sense, calling a variable button1 or calling it circleButton? Which variable name would make debuggin easier?
• Learn and use a CardLayout to do your swapping for you. If you use this, you won't have to call revalidate and repaint on the container that holds your drawing JComponents (something that you're not doing now anyway).

Luck!

alrite, thanks alot moderator! I will try your suggestions! :(y):

@moderators: I tried to do this as suggested by Fubarable

Code:

---

JPanel panelButton = new JPanel();
  panelButton.setLayout(new BorderLayout());

  panelButton.add(button);
  panelButton.add(button1);
  frame.add(panelButton, BorderLayout.NORTH);

---

But the output is only the last component is displayed. Can you explain to me why it happens and give me hints to solve this?

The BorderLayout manager needs instructions on where you want it to place your components. These are called constraints in the syntax for the add method.
If you don't give any instructions/constraints it uses the default which probably says to put them all in the same place. One on top of the other. Read the API doc for the BorderLayout class for examples.

I have looked at the API doc but still don't really understand (sorry I start to learn java from 2 months ago). Can you give me an example?

Did you try any of the examples in the API doc?
For example:

Code:

---

add(new Button("North"), BorderLayout.NORTH);

---

This will put a button in the North section of the layout.

oh I never tried this one, alrite I will try it now, thx Moderator