Inserting rows to jtable with custom model

[d3n1s]

Hello everyone

I have created a jtable with a custom model that extends defaulttablemodel. The issue is that my insertRow method does not insert a blank line for me to type the new values at the bottom. I am using a hashmap with a point variable for the key. there are no exceptions or anything, just that nothing happens (i checked with the netbeans debugger and it is being called...)

Any ideas?

private class EntityTableModel extends DefaultTableModel
    {
        private HashMap lookup;
        private int rows;
        private int columns;
        private String[] headers;
        
        public EntityTableModel(String[] headers, int rows)
        {
            this.rows = rows;
            this.headers = headers;
            this.columns = headers.length;
            lookup = new HashMap();
        }
        
        @Override
        public Object getValueAt(int row, int col)
        {
            return lookup.get(new Point(row, col));
        }
        
        @Override
        public void setValueAt(Object value, int row, int column)
        {
            if ((rows < 0) || (columns < 0))
            {
                throw new IllegalArgumentException("Invalid row/column setting");
            }
            if ((row < rows) && (column < columns))
            {
                lookup.put(new Point(row, column), value);
            }
            fireTableCellUpdated(row, column);
        }
        
        @Override
        public int getColumnCount()
        {
            return columns;
        }
        
        @Override
        public int getRowCount()
        {
            return rows;
        }
        
        @Override
        public String getColumnName(int column)
        {
            return headers[column];
        }
        
        @Override
        public void insertRow(int row, Object[] rowData)
        {
            int columnCount = getColumnCount();
            for (int i = 0; i < columnCount; i++)
            {
                lookup.put(new Point(row, i), new Object());
            }
            fireTableDataChanged();
        }
    }

[DarrylBurke]

Moved from Advanced Java

db

[eRaaaa]

Thats because your getRowCount() method still returns the old rows value!
The whole model looks a bit funny!
Usually you would add an object to a list, and then return the list.size() at the getRowCount method .I do not understand why you used the point class here

[d3n1s]

Well a hashmap has 2 "columns" and i needed 3 so i thought what the heck, it works pretty well! Anyway i added rows++ in my method and it works like a charm! Thanks so much!

[camickr]

You should NOT be extending DefaultTableModel. The DefaultTableModel already implement storage for the rowcolumn data and the headings. There are many method of the DefaultTableModel that you did not override. If somebody happens to invoke those methods then they will be referring to the data of the DefaultTableModel and not your custom model.

Instead, because you are implementing your own storage you should be extending AbstractTableModel directly.

[d3n1s]

Good tip! What do you think about the hashmap idea?

[camickr]

You haven't stated what your requirement is, or what is wrong with the DeaultTableModel, so I would say I don't like your Hashmap idea because it appears you are reinventing the wheel for no reason.