square moves left and down but not up or left

[natdizzle]

when you run this you should be able to press the right and down arrow keys which move the square, but up and left keys do not move the square as it should .. do you know why this is?

import java.awt.Color;
import java.awt.Frame;
import java.awt.Graphics;
import javax.swing.JComponent;
import javax.swing.JFrame;
import javax.swing.Timer;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyAdapter;
import java.awt.event.KeyEvent;

public class square{
	int x;
	int y;
	int movespeed = 4;

	public static void main(String[] args) {
        javax.swing.SwingUtilities.invokeLater(new Runnable() {
            public void run() {
            	new square();
            }
        });
	}
	public square(){
		JFrame panel = new JFrame();
		panel.setExtendedState(Frame.MAXIMIZED_BOTH);
		panel.setSize(600, 400);
		panel.setVisible(true);
		panel.getContentPane().add(new painting());
		panel.requestFocusInWindow();
		panel.addKeyListener(new moving());
	}
	@SuppressWarnings("serial")
	public class painting extends JComponent{
	    public void paint(Graphics g){
	      g.setColor(Color.red);
	      g.fillRect(x,y,50,50);
	      repaint();
	    }
	  }

	public class moving extends KeyAdapter implements ActionListener{
		boolean up = false;
		boolean down = false;
		boolean left = false;
		boolean right = false;
		public moving(){
			Timer timer = new Timer(55, this);
			timer.start();
		}
		@Override
		public void keyPressed(KeyEvent arg0) {
			 switch(arg0.getKeyCode())
			  {
			     case KeyEvent.VK_LEFT: left = true;
			     case KeyEvent.VK_RIGHT: right = true;
			     case KeyEvent.VK_UP: up = true;
			     case KeyEvent.VK_DOWN: down = true;
			  }
}

		@Override
		public void keyReleased(KeyEvent arg0) {
			  switch(arg0.getKeyCode())
			  {
			     case KeyEvent.VK_LEFT: left = false;
			     case KeyEvent.VK_RIGHT: right = false;
			     case KeyEvent.VK_UP: up = false;
			     case KeyEvent.VK_DOWN: down = false;
			  }
		}
		@Override
		public void keyTyped(KeyEvent arg0) {
			// TODO Auto-generated method stub
			
		}
		public void actionPerformed(ActionEvent ac) {
				  if(left && down){
				     x = x - movespeed;
				     y = y + movespeed;
				  }
				  if(left && up){
					 x = x - movespeed;
				     y = y - movespeed;
				  }
				  if(left){
					 x = x - movespeed;
				  }
				  if(right && down){
					 x = x + movespeed;
				     y = y + movespeed;
				  }
				  if(right && up){
					 x = x + movespeed;
				     y = y - movespeed;
				  }
				  if(right){
					 x = x + movespeed;
				  }
				  if(down){
				     y = y + movespeed;
				  }
				  if(up){
				     y = y - movespeed;
				  }
			}
		}
		
	}

[KevinWorkman]

You need to break out of each case in your switch statement, otherwise it will fall through and do anything below it.

Recommended reading: The switch Statement (The Java™ Tutorials > Learning the Java Language > Language Basics)

[JosAH]

switch(arg0.getKeyCode())
{
case KeyEvent.VK_LEFT: left = true;
case KeyEvent.VK_RIGHT: right = true;
case KeyEvent.VK_UP: up = true;
case KeyEvent.VK_DOWN: down = true;
}

You should put a couple of 'break' statements there, otherwise the control flow 'falls through', e.g. if the key code equals VK_UP both up and down are set to the value true.

kind regards,

Jos

edit: @KevinWorkman: don't do that! It's driving me crazy to be the slowest old sod in town! ;-)

[natdizzle]

thanks that should fix it