Static methods or individual classes?

[nik_meback]

My swing application file has quite a few static methods which I plan to remove by creating a separate class for each static method in the same folder and then use the methods of these classes in my application file. Does it matter which approach I take? If yes, which approach is better - using a lot of static methods in my app OR writing a class for each static method?

[KevinWorkman]

Why would you write a class for each static method? What do these methods do?

It matters which approach you take. But only to you. We can't really tell you what approach is best, especially without seeing any code (no, that doesn't mean paste all your code here). Try an approach. Does it work?

[nik_meback]

The app structure looks something like this:

public class MyApp
{
static JMenuBar createMenuBar()
{
// create menu bar
}
static JToolBar createToolBar()
{
// create toolbar
}
static JLabel createStatusBar()
{
// create status bar
}

ActionListener ac = new ActionListener()
{
// handling swing events...
};

JFrame myFrame = new JFrame();
myFrame.setVisible(true);
...
...
}

[KevinWorkman]

I guess the question is, why are these methods static in the first place?

Dollar bet: You did that to resolve "non-static XYZ referenced from static context" exceptions, didn't you? DIDN'T YOU. :p

[nik_meback]

er... yes. Is that an incorrect methodology?

[KevinWorkman]

Yes and no. It's common for a "newbie" (or even a mid-level or slightly experienced) programmer to use the "quick fix" for that kind of Exception without actually understanding what the problem is.

I am betting you actually have something like this:

public class MyApp
{
   static JMenuBar createMenuBar(){
      // create menu bar
   }
   static JToolBar createToolBar(){
      // create toolbar
   }
   static JLabel createStatusBar(){
      // create status bar
   }

   public static void main(String [] args){

      JFrame frame = new JFrame();

      //pseudocode, but you get the point
      frame.add(MyApp.createMenuBar());
      frame.add(MyApp.createToolBar());
      frame.add(MyApp.createStatusBar());
   }
}

When really you should have something more like:

public class MyApp
{
   public JMenuBar createMenuBar(){
      // create menu bar
   }
   public JToolBar createToolBar(){
      // create toolbar
   }
   public JLabel createStatusBar(){
      // create status bar
   }

   public static void main(String [] args){

      JFrame frame = new JFrame();
 
      MyApp appInstance = new MyApp();

      //pseudocode, but you get the point
      frame.add(appInstance.createMenuBar());
      frame.add(appInstance.createToolBar());
      frame.add(appInstance.createStatusBar());
   }
}

That's just guessing at what you're doing, but I'm hoping it demonstrates the point.

[nik_meback]

thanks. i'll correct that one.