trouble animating

[rippon]

myThing is a rectangle, which I want to see move horizontally a bit. But this doesn't happen; the rectangle just flickers a bit in its original position, which is where it stays put.
Would appreciate any help; thanks.

public class MovingThing extends JFrame
{
...
  private Thing myThing = new Thing();

...
    public void paint(Graphics g)
    {
        super.paint(g);
        myThing.paint(g);
    }

    private class TryThisButtonWatcher implements ActionListener
    {
      ActionListener moveHorizontally = new ActionListener()
      {
        public void actionPerformed(ActionEvent a)
        {
            for (int i=0; i<10; i++)
            {
              myThing.setParams(100+5*i,300,100,50);
              repaint();
            }
        }
      };
        Timer myTimer = new Timer(1000, moveHorizontally);
        public void actionPerformed(ActionEvent a)
        {
            myTimer.start();
        }
    } // end of: private class TryThisButtonWatcher implements ActionListener

...
...
}


public class Thing extends JComponent
{
    private int one, two, three, four;

    public Thing()
    {
    }
    
    public void paint(Graphics g)
    {
        super.paint(g);
        g.drawRect(one, two, three, four);
    }
    
    public void setParams(int a, int b, int c, int d)
    {
        one = a; two = b; three = c; four = d;
    }

} // end of: public class Thing extends JComponent

[Fubarable]

For me at least there are too many details unknown here. You should try to create a very small compilable and runnable program that demonstrates your problem. It won't need a JButton, just a JPanel to do your drawing in (you should paint in the JPanel's paintComponent method, never the JFrame's paint method). In short, an SSCCE.

Luck!

[Fubarable]

Perhaps my example code here may help you.

[rippon]

Thanks, you're right, good advice. I will go away and think about this, and, in isolating my problem in an SSCCE, I might be able to resolve this.