keyListener not doing anything

[imorio]

I wanted to add hotkeys to my program, so I made my class implement KeyListener, added the methodes and added a keylistener. But somehow, when I ran the program and clicked a key, the methode wasn't called, so clicking keys did nothing. Then I wrote a simple program, just to test if I could make any program respond to key-input. However this simple program also did nothing.

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
public class testClass extends JFrame implements KeyListener
{
	private boolean rectangle=false;
	public toren()
	{
		setTitle("test");
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		setSize(500, 500);
		setLocation(0,0);
		getContentPane().setBackground(Color.white);
		((Component) getContentPane()).addKeyListener(this);
		setVisible(true);
	}
	public void paint(Graphics g)
	{
		g.drawRect(50, 50, 50, 50);
		if(rectangle)
		{
			g.drawRect(50, 50, 100, 100);
		}
	}
	public void keyPressed(KeyEvent e) {
	}
	public void keyReleased(KeyEvent e) {
	}
	public void keyTyped(KeyEvent e) {
		rectangle=true;
		repaint();
	}
}

Because the methode just isn't called, debugging didn't help. My question is, what am I doing wrong?

[PhHein]

Use KeyBindings instead of a keyListener, especially if you want a hotkey function for the complete frame.

[imorio]

ok, I went for keybinders (after looking up what they are), so now my code is:

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
public class toren extends JFrame implements KeyListener
{
	private boolean rectangle=false;
	public toren()
	{
		setTitle("tower defence");
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		setSize(500, 500);
		setLocation(0,0);
		getContentPane().setBackground(Color.white);
		((Component) getContentPane()).getInputMap(WHEN_IN_FOCUSED_WINDOW).
put(KeyStroke.getKeyStroke("b"),"doSomething");//<error
		((Component) getContentPane()).getActionMap(WHEN_IN_FOCUSED_WINDOW).
put("doSomething",rectangle());//<error
		setVisible(true);
	}
	public void paint(Graphics g)
	{
		g.drawRect(50, 50, 50, 50);
		if(rectangle)
		{
			g.drawRect(50, 50, 100, 100);
		}
	}
	public void keyPressed(KeyEvent e) {
	}
	public void keyReleased(KeyEvent e) {
	}
	public void rectangle() {
		rectangle=true;
		repaint();
	}
}

".getInputMap(WHEN_IN_FOCUSED_WINDOW)" and ".getActionMap(WHEN_IN_FOCUSED_WINDOW)" still give an error. The statement seems wrong to me, but the sun tutorial doesn't give me any clue how the statement should read.

[PhHein]

	public toren() {
		setTitle("tower defence");
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		setSize(500, 500);
		setLocation(0, 0);
		getContentPane().setBackground(Color.white);
		((JComponent) getContentPane()).getInputMap (JComponent.WHEN_IN_FOCUSED_WINDOW).put(
				KeyStroke.getKeyStroke('b'), "doSomething");
		((JComponent) getContentPane()).getActionMap()
				.put("doSomething", doPaint);
		setVisible(true);
	}

	Action doPaint = new AbstractAction() {
	    public void actionPerformed(ActionEvent e) {
	       rectangle();
	    }
	};

And please read the custrom painting tutorial before you continue.

[imorio]

	public toren() {
		setTitle("tower defence");
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		setSize(500, 500);
		setLocation(0, 0);
		getContentPane().setBackground(Color.white);
		((JComponent) getContentPane()).getInputMap (JComponent.WHEN_IN_FOCUSED_WINDOW).put(
				KeyStroke.getKeyStroke('b'), "doSomething");
		((JComponent) getContentPane()).getActionMap()
				.put("doSomething", doPaint);
		setVisible(true);
	}

	Action doPaint = new AbstractAction() {
	    public void actionPerformed(ActionEvent e) {
	       rectangle();
	    }
	};

And please read the custrom painting tutorial before you continue.

Thank for the help. However the tutorial you recommended is rather bad. It uses the style "add code x, this will have result y", which is great when everything works. However after trying to add this code to my program, my program gave all kinds of errors and stopped working. Now with 20 lines of code in my program which I have no clue what they do, fixing this is almost impossible. My only option left is te remove all the code from the tutorial and return to the last state of my program that still worked.

[PhHein]

First of all you should not do any painting on the contentPane, but in a JPanel which is added to the contentPane. Then the tutorial code starts working automagically.

[imorio]

First of all you should not do any painting on the contentPane, but in a JPanel which is added to the contentPane. Then the tutorial code starts working automagically.

I did that, and now all I get is a list of error messages:

Exception in thread "AWT-EventQueue-0" java.lang.IllegalArgumentException: adding a window to a container
	at java.awt.Container.checkNotAWindow(Unknown Source)
	at java.awt.Container.addImpl(Unknown Source)
	at java.awt.Container.add(Unknown Source)
	at javax.swing.JFrame.addImpl(Unknown Source)
	at java.awt.Container.add(Unknown Source)
	at tester.startEditor(tester.java:23)
	at tester$1.run(tester.java:14)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

I painted the squares I wanted using pixels (as in "g.drawRect(x1, y1, x2, y2)" with x1-y2 being ints), could that cause problems?

[Fubarable]

I think your problem is coming from somewhere else. It looks as if you're trying to add a JFrame (or other top level container) to a JPanel (or other Container).

Perhaps you should show us the code that is causing the error.

[imorio]

I think your problem is coming from somewhere else. It looks as if you're trying to add a JFrame (or other top level container) to a JPanel (or other Container).

Perhaps you should show us the code that is causing the error.

Thanks, I was extending JFrame when I should have been extending JPanel. Most of my program is working again with the huge improvement that when part of the window gets blocked, the content returns when it is unblocked. My only problem left is my JMenuBar.

Adding it in the JPanel class editor (where I do almost everything) doesn't compile, using a get methode to get the menuBar from "editor" and then adding it in the tester class doesn't work either. If I add it after the JPanel, the whole screen turns into one big menuBar and when I add the menuBar first, it just doesn't show up. I tried moving the JPanel 50 pixels down, but that just revealed empty background.

import java.awt.*;
import java.util.*;
import javax.swing.*;
public class tester
{
	public static void main(String[] args)
	{
		SwingUtilities.invokeLater
		(
			new Runnable()
			{
				public void run()
				{
					startEditor();
				}
			}
		);
    }
	public static void startEditor()
	{
		JFrame f = new JFrame("towerDefence: editor");
		f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		editor e= new editor();//editor extends JPanel
		f.add(e.getMenuBar());
		f.add(e);
		f.pack();
		f.setVisible(true);
	}
	public static void nieuwSpel(ArrayList<Point> route, int veldGrootte)
	{
		new spel(route, veldGrootte);
	}
}

[Fubarable]

Thanks, I was extending JFrame when I should have been extending JPanel.

That makes more sense for the error that you're seeing.

Most of my program is working again with the huge improvement that when part of the window gets blocked, the content returns when it is unblocked. My only problem left is my JMenuBar.

Adding it in the JPanel class editor (where I do almost everything) doesn't compile,...

I don't understand this since a JMenuBar extends from JComponent, you should be able to add it to a JPanel without any difficulty. Again, showing us code and the actual error message would help us greatly.

using a get methode to get the menuBar from "editor" and then adding it in the tester class doesn't work either. If I add it after the JPanel, the whole screen turns into one big menuBar and when I add the menuBar first, it just doesn't show up. I tried moving the JPanel 50 pixels down, but that just revealed empty background.

import java.awt.*;
import java.util.*;
import javax.swing.*;
public class tester
{
	public static void main(String[] args)
	{
		SwingUtilities.invokeLater
		(
			new Runnable()
			{
				public void run()
				{
					startEditor();
				}
			}
		);
    }
	public static void startEditor()
	{
		JFrame f = new JFrame("towerDefence: editor");
		f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		editor e= new editor();//editor extends JPanel
		f.add(e.getMenuBar());
		f.add(e);
		f.pack();
		f.setVisible(true);
	}
	public static void nieuwSpel(ArrayList<Point> route, int veldGrootte)
	{
		new spel(route, veldGrootte);
	}
}

Have a look at the JFrame API and you'll see a method that is used for specifically adding a JMenuBar to a JFrame, setJMenuBar. When you run into similar problems, always go to the API before coming here as it will likely give you the answer quicker and is a good skill to master.

[Norm]

f.add(e.getMenuBar());

What kind of component does the getMenuBar() method return?
Is it appropriate to be adding that component to the content pane?
See the JFrame class for other types of add/set methods