Moving an image on a JFrame

[jinkazama]

Hi There

I am trying to learn some simple animation with Java and swing. The code below should create a frame and add a simple graphic to the screen. I have then added a Key Listener to capture the left and right cursor keys.

When the left or right key is pressed the image should move left or right. Currently it draws the image onto the frame and that is all I get, your advise is appreciated:

package animationtest;  
  
public class AnimationTestStart {  
  
    public static void main(String[] args)  
    {  
        Animation world = new Animation("Animation");  
        world.setVisible(true);  
        world.run();  
          
    }  
      
} 



    
package animationtest;  
  
import java.awt.*;  
import javax.swing.*;  
import java.awt.event.*;  
  
public class Animation extends JFrame{  
      
    Image image;  
    private SpaceShip player1 = new SpaceShip();  
      
    public Animation(String title) {  
        setTitle(title);  
        setSize(400,400);  
        setLocation(100,100);  
        setBackground(Color.black);  
        setDefaultCloseOperation(EXIT_ON_CLOSE);  
        addKeyListener( new KeyList());  
    }  
      
    public void run() {  
          
        while (true) {  
              
            repaint();  
              
        }  
    }  
      
    public void paint(Graphics g) {  
             player1.paint(g);  
             repaint();  
    }  
      
    private class KeyList extends KeyAdapter {  
        public void keyPressed(KeyEvent k) {  
            if (k.getKeyCode() == KeyEvent.VK_LEFT){  
                player1.moveLeft();  
            }  
            if (k.getKeyCode() == KeyEvent.VK_RIGHT){  
                player1.moveRight();  
            }  
        }  
    }  
}  
  



package animationtest;  
  
import java.awt.*;  
import javax.swing.*;  
  
public class SpaceShip extends JFrame{  
    Image image;  
    private int yMove = 370;  
    private int xMove = 200;  
      
    public SpaceShip() {  
          
        image = getToolkit().getImage("SpaceShip.JPG");  
    }  
      
    public void paint(Graphics g) {  
        g.drawImage(image, xMove, yMove, this);  
    }  
      
    public void moveLeft() {  
        xMove = xMove--;  
    }  
      
    public void moveRight() {  
        xMove = xMove++;  
    }  
      
    public void moveReset(int value) {  
        xMove = value;  
    }  
}

[camickr]

You where given the answer to this questions yesterday when you cross posted the question in this forum:

Simple Animation. (Swing / AWT / SWT / JFace forum at JavaRanch)

[jinkazama]

Hi Rob

Thank you for help with this request, I was hoping for a different explanation why the program does not work.

Reading through the Swing manual and looking at Key Bindings has not really answered why the code I have put together does not do what I intended.

Cheers

Jin.

[Fubarable]

Hi Rob
Thank you for help with this request, I was hoping for a different explanation why the program does not work.

Thanks for desiring us to repeat work that has already been done. Next time, please let us know, else you could be on several black-lists or banned.

Rob thanks for the warning.

Reading through the Swing manual and looking at Key Bindings has not really answered why the code I have put together does not do what I intended.

No, but in answers how do do what you are desiring correctly. Which is more important?

Edit: On review of the cross-post, I see that Rob did in fact give you the explanation for why you code doesn't work.