Problem with painting the contents of a file on a JTextArea

[Willi]

Hi friends!

Recently I am trying to implement this problem : Paint the contents of a file (text file) on to a JTextArea. For the first look, it seems to work well, but actually when I take a deeper look at the output, I realized that the contents of the file are not fully displayed on the JTextArea. That is, some parts of the text file are not displayed and some parts are displayed clearly.

After studying the code clearly, I cannot find out any problem and decide to get help from professional :mad:. Here is the code, please help me :mad:

import java.awt.*;
import javax.swing.*;
import java.io.*;

public class TextAreaTest
{
   public static void main(String[] args) 
   {
      EventQueue.invokeLater(new Runnable()
         {
            public void run() 
            {
		  try 
                  {
                      TextAreaFrame frame = new TextAreaFrame();
                      frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
                      frame.setVisible(true);
		  }
		  catch(IOException e)
		  {
		     e.printStackTrace();
		  }
            }
         });
   }
}

class TextAreaFrame extends JFrame 
{
    private JTextArea textArea;
    public TextAreaFrame() throws IOException
    {
	setTitle("JIE");
	setSize(500, 400);

	textArea = new JTextArea(20, 60);	
	textArea.setLineWrap(true);
        textArea.setEditable(false);
	textArea.setFont(new Font("Vrinda", Font.BOLD, 23));

	JScrollPane scrollPane = new JScrollPane(textArea);

	add(scrollPane);

	pack();

	FileInputStream fis = new FileInputStream("haha.txt"); // display the contents of the file [B]haha.txt[/B]
	BufferedReader bd = new BufferedReader(new InputStreamReader(fis));

       String line;
       while((line = bd.readLine()) != null)
       {
	    textArea.append(bd.readLine());
	    textArea.append("\n");
       }
    }    
}

Thank you!

[r035198x]

Don't use those streams for reading text data. Use FileReader/BufferedReader instead.
Alternatively, read the API specs for the JTextComponent.read method.

[PhHein]

Hi Willi,

you're skipping lines:

while((line = bd.readLine()) != null) // <-----read here
       {
	    textArea.append(bd.readLine()); // <----read again
	    textArea.append("\n");
       }

So you should append line:

while((line = bd.readLine()) != null) // <-----read here
       {
	    textArea.append(line); 
	    textArea.append("\n");
       }

And you should consider using a Scanner:

Scanner s = new Scanner(new File("haha.txt"));
while (s.hasNext()) {
	textArea.append(s.nextLine());
	textArea.append("\n");
}

EDIT: sloooow

[Willi]

Great thanks!

hi r03198x : actually I used BufferedReader but it still does not work well. It just print a part of the file and some lines are lost. Can you explain for me why? thanks :D

to PhHein : the best way is to create an object of the class File to hold a file and then read from it using FileReader. Thanks for your reply :D

[PhHein]

to PhHein : the best way is to create an object of the class File to hold a file and then read from it using FileReader.

Why? Where did you get that from?

[r035198x]

Please read the messages posted already.

[PhHein]

Sorry r035198x, I'm a bit dense today. Rereading the posted messages doesn't give me a clue.

[r035198x]

Sorry r035198x, I'm a bit dense today. Rereading the posted messages doesn't give me a clue.

Go away.

I was just too lazy to quote the OP.

r035198x(<----Lazy bum.

[PhHein]

Great, just great. Sums up my day :)

[Willi]

Why? Where did you get that from?

I mean for my problem, create a File object is the best way and that is what you advise me to do. Because I just try to make a BufferedReader object and it does not work well. Can you explain for me why? Is this the problem of the buffer? :confused:

[r035198x]

Did you use FileReader with it like I suggested?
Did you read the API specs for that read method like I suggested?
Did you read any of the responses posted in this thread?

[Willi]

Hey easy brother! What happen to you? I try that program according to your advice, and here is the code, it works perfect.

import java.awt.*;
import javax.swing.*;
import java.io.*;

public class TextAreaTest
{
   public static void main(String[] args) 
   {
      EventQueue.invokeLater(new Runnable()
         {
            public void run() 
            {
		  try {
                  TextAreaFrame frame = new TextAreaFrame();
                  frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
                  frame.setVisible(true);
		  }
		  catch(IOException e)
		  {
		     e.printStackTrace();
		  }
            }
         });
   }
}

class TextAreaFrame extends JFrame 
{
    JTextArea textArea;
    public TextAreaFrame() throws IOException
    {
	setTitle("JIE");
	setSize(500, 400);

	textArea = new JTextArea(20, 60);	
	textArea.setLineWrap(true);
	textArea.setFont(new Font("Vrinda", Font.BOLD, 23));
	JScrollPane scrollPane = new JScrollPane(textArea);

	add(scrollPane);

	pack();

[B]        // CODE CHANGED HERE 
	File inputFile = new File("haha.txt");
	FileReader fr = new FileReader(inputFile);[/B]

	int c;
	while((c = fr.read()) != -1)
	{
	    textArea.read(fr, fr.toString());
	    textArea.append("\n");
	}

	fr.close();
    }    
}

Now i just want to ask why does BufferedReader not work as well as FileReader :(

[camickr]

A BufferedReader does work better than a file reader.

The suggestion was to use the JTextComponent.read(...) method, not the BufferedReader.read(...) method. Using the JTextComponent.read() its one line of code. Using the BufferedReader.readln(...) method you need to create your own loop.