mouseListener trouble please help!

[linux1man]

Hi everybody!

I am working on a Battle Ship game, and i am having some issues with Mouse listener. The problem is i can not add a mouselistener to JFrame, or JPane. Why? here's my code below (all the other stuff works, just the line with the comment gives an error when i add it.

import javax.swing.*;
import javax.imageio.ImageIO;
import java.awt.*;
import java.io.File;
import java.io.IOException;
import java.io.BufferedInputStream;
import java.io.FileInputStream;
import javazoom.jl.player.Player;
import java.awt.event.MouseListener;
import java.awt.event.MouseEvent;

public abstract class BattleShip extends JFrame implements MouseListener
{
    public static void showSplash()
	{
		MP3 pirates = new MP3("pirates.mp3");
		pirates.play();
		JFrame frame = new JFrame("Battle Ship");
        frame.setSize(490, 320);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

        Image backgroundImage = null;
        String pathToTheImage = "splash.jpg";
        try 
		{
            backgroundImage = ImageIO.read(new File(pathToTheImage));
        } 
		catch (IOException e) 
		{
            e.printStackTrace();
        }
        ImagePanel panel = new ImagePanel(backgroundImage);
		
		panel.addMouseListener(mouseClicked); // ******* ERROR ****/
        frame.getContentPane().add(panel);
		frame.setResizable(false);
        frame.show();
	}
	
	public static void showgameScreen()
	{
		JFrame frame = new JFrame("Battle Ship");
        frame.setSize(800, 600);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

        Image backgroundImage = null;
        String pathToTheImage = "grid.jpg";
        try 
		{
            backgroundImage = ImageIO.read(new File(pathToTheImage));
        } 
		catch (IOException e) 
		{
            e.printStackTrace();
        }
        ImagePanel panel = new ImagePanel(backgroundImage);

        frame.getContentPane().add(panel);
		frame.setResizable(false);
        frame.show();
	}
	
	public void mouseClicked(MouseEvent e) 
	{
        int x = e.getX();
		int y = e.getY();
		if ((x >= 370 && x <= 470) && (y >= 275 && y <= 230))
		{
			System.exit(1);
		}
    }

	
	public static void main(String[] args) 
	{
		showSplash(); 
	}
}

[Steve11235]

Let me give you a suggestion, and then I'll explain why.

Put a single JPanel in the JFrame, and put everything else in the JPanel. You can set the JFrame layout manager to GridLayout with no parameters, and the JPanel will fill the JFrame. This is one of my "always do" practices.

The reason is this: JFrame cannot hold components directly. It actually has a JRootPane, which in turn has several other panes. JFrame has "convenience methods" to add components and what not, which means that you can use the JFrame methods to work on the pane that actually holds the components, but that can lead to confusion.

Adding a JPanel to the JFrame means that you have a component you defined that contains everything else, so you can see exactly what is going on.

You can add a mouse listener to the JPanel. Keep in mind that if you add components to the JPanel, they may intercept the mouse events. I haven't experimented with that, so this is just something to keep in mind if things don't happen the way you expect.

[Fubarable]

The error is because you're trying to pass a method to your addMosueListener method when instead you must pass a MouseListener object which in this situation would be "this".

I agree with Steve that you should do your work in a JPanel. Also, try to avoid having your GUI classes implement Listener interfaces. You're much better off adding an anonymous MouseAdapter object to your addMouseListener method.

[Steve11235]

Oops... That's why Fubarable is the moderator, he actually reads the code!

[linux1man]

Thanks for the help!
I forgot about JPane (just started doing GUI's last week)

[Darryl.Burke]

Also, show() is deprecated. Use setVisible(true) instead.

db

[linux1man]

ok, thanks