Printable View
Say you click a button which loops a process, but you want to terminate that process when you click the button again, or press some key.
So for example, I registered the listener object with the button. When I press the button, it triggers an ActionEvent and goes to the actionPerformed method wherein it loops some process. I want to make it so that the loops ends if the user decides to press a key(or something else that triggers an event).
How do you do that?
have the button set a boolean that the loop checks, and then bails out if the boolean is true.
No.
I have a way to terminate the loop if the key is pressed, I don't need a boolean value.
The problem is, if I press the key during the loop(during the initial event), KeyEvent isn't fired.
What component am I supposed to register the keylistener object to?
I generally don't use key listeners unless an absolute necessity. Usually I use key binding instead, and I bind it to whatever happens to be the most logical component at the time.
And yes, I still recommend that the keybinding change a boolean and that this bump you out of the loop.
It can be anything, it doesn't have to be a key.
How can I check for an event during an event?
...
I have an instance variable(an integer which the loops relies on) which gets changed if the KeyEvent is fired. I DON'T need a boolean.
Since you're asking the question, how do you know for sure what you need or don't need?Quote:
Originally Posted by infinity
Even for loops can contain either boolean conditions or boolean-induced breaks. For instance:
But I think that you need to give more detail and some code here for better answers. We can't begin to guess what's in your code at present. Perhaps you shouldn't be using a for loop here, but rather a SwingWorker background thread or a Swing Timer. But again without more information, all we can do is guess.Code:boolean quit = false;
for (int i = 0; i > MAX && !quit; i++)
{
//....
}
I'm not asking for help on terminating a loop.
IF the KeyEvent is fired, it will change the instance variable, and thus end the loop in the ongoing ActionEvent(by the button).
Part of the problem is that I don't know what component to register the KeyListener object to.
Again, you probably don't want to use a KeyListener but rather use key bindings. The sun tutorials will give a decent explanation why you should do this. Other than that, I'm lost as I have no idea really what your main question is. Sorry.Quote:
Originally Posted by infinity
I think that your best bet here is to show us your code. We don't want to see all of it, but rather you should condense your code into the smallest bit that still compiles, has no extra code that's not relevant to your problem, but still demonstrates your problem, in other words, an SSCCE (Short, Self Contained, Correct (Compilable), Example). For more info on SSCCEs please look here:
Short, Self Contained, Correct Example
Again, if the code is compilable and runnable more people will be able to help you.
Also, what is this loop that's within the button's action listener doing, both in a coding sense and in a general program structure sense?
I don't know what key binding is
Code:// instance variable
private boolean exit;
...
//inside some method
JButton x = new JButton("x");
x.addActionListener(new act());
...
public class act implements ActionListener{
public void actionPerformed(ActionEvent event){
while(!exit)
process();
}
}
...
public class keys implements KeyListener{
public void keyPressed(KeyEvent k){
if(k.getKeyCode()==KeyEvent.VK_Q)
exit=true;
}
public void keyReleased(KeyEvent k){}
public void keyTyped(KeyEvent k){}
}
the Sun Swing tutorials will answer this for you. Again, search the tutorial (go to the "Really Big Index" and search on binding) and have a look. It will open your eyes.Quote:
Originally Posted by infinity
this code isn't compilable, making it hard to fully analyze.Quote:
Code:// instance variable
private boolean exit;
...
This looks to be a loop that will lock up the EDT, the Event Dispatch Thread, causing your app to lock up. do you notice that when the loop is triggered, your app becomes completely unresponsive to button presses and whatnot? If so, you really should look to doing this loop in either a SwingWorker background thread or use a Swing Timer, both as suggested above.Quote:
Code:public class act implements ActionListener{
public void actionPerformed(ActionEvent event){
while(!exit)
process();
}
}
yep, it locks up my app
i'll check the stuff out, thanks
again, what is the process method doing? what is the goal of all of this?
it's a bot
the process moves the mouse at certain locations, clicks, and repeats
Use a Swing Timer then.
For instance, here is my SSCCE:
Note that this is a fully compilable runnable program to demonstrate an issue, an SSCCE.Code:import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JComponent;
import javax.swing.Timer;
public class ShowTimer
{
public static final int TIMER_DELAY = 200;
private JPanel mainPanel = new JPanel();
Timer swingTimer;
public ShowTimer()
{
JButton toggleProcess = new JButton("Toggle Process");
toggleProcess.addActionListener(new ToggleBtnListner());
mainPanel.add(toggleProcess);
}
public void process()
{
System.out.println("process active");
}
public JComponent getComponent()
{
return mainPanel;
}
private class ToggleBtnListner implements ActionListener
{
public void actionPerformed(ActionEvent e)
{
if (swingTimer != null && swingTimer.isRunning())
{
swingTimer.stop();
swingTimer = null;
}
else
{
swingTimer = new Timer(TIMER_DELAY, new ActionListener()
{
public void actionPerformed(ActionEvent e)
{
process();
}
});
swingTimer.start();
}
}
}
private static void createAndShowUI()
{
JFrame frame = new JFrame("ShowTimer");
frame.getContentPane().add(new ShowTimer().getComponent());
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.pack();
frame.setLocationRelativeTo(null);
frame.setVisible(true);
}
public static void main(String[] args)
{
java.awt.EventQueue.invokeLater(new Runnable()
{
public void run()
{
createAndShowUI();
}
});
}
}
i haven't taken any formal classes on swing, i learned what i know from a book
i'm not too familiar with what you're doing
is that threading?
than you're one up on me as I've taken no formal classes nor gone through a book.Quote:
Originally Posted by infinity
No, that's using a Swing Timer object. You can learn more about it by going through the appropriate Sun tutorial: How to Use Swing Timers (The Java™ Tutorials > Creating a GUI with JFC/Swing > Using Other Swing Features)Quote:
i'm not too familiar with what you're doing
is that threading?
Well technically it is threading, though not explicitly. Any time you use a listener or a SwingTimer you are writing multi-threaded code. To be able to use these correctly and efficiently you need to know about how threading works. Fortunately, Sun provides hand tutorials, available via some of the links already given.
True, as long as the OP understands that while the Swing Timer runs the timer itself in a background thread, that none of the processes run in the Timer's ActionListener are done in a background thread, that it's all done on the main Swing thread, the EDT.Quote:
Originally Posted by OrangeDog