java recursion infinite loop

[tony404]

Hi i need to go over tree in java and print all the nodes
tempdata is the node structe:

class DataType {
String name;
LinkList DataType ;

getList{

return DataType
}
}

public void printTree(DataType node) {

DataType root = node;
while (!root.getList().isEmpty())
{
LinkedList list1 = root.getlinklist();
Iterator i = list1.iterator();
while (i.hasNext()) {
dataType tempDataType= (dataType)i.next();
printTree(tempDataType);
System.out.println( tempDataType.getName());

}

}
}

this soulution is infinite i get infinte loop
can any one suggent soultion to this probelm or any easy way to go over the tree and printed it. (it;s tree of tree)
10x.

[Eranga]

Is this working at all?

[tony404]

the result is infinite loop

[Eranga]

Change this,

while (!root.getList().isEmpty())

as this

while (root.getList().isEmpty())

[tony404]

but then i will not enter to the loop anytime

[Eranga]

Ya, that's what I want to know. Just after that try to find the number of elements have in the list. If there is specific number of elements then something going wrong with the rest of the code.

[tony404]

i fixed it by adding check if i visit in the node or not
while (!node.getIparamGroupChildren().isEmpty() && !node.isVisited())

[Eranga]

It's much better. Everything is fine now? In such a case start from the most outer loop. Check the possibilities it can have, and move to inner loops. Then you can find the firing condition for infinite loop.

[Niveditha]

Hello tony,
Can u tell me which tree nodes r u trying to print? Is it a JTree,binary tree or any other such tree.

[kellaw]

use do while to make it execute at least once