Best practice of IF loop with NOT

[sathishranganathan]

Hi,

Please suggest me the best practice of using if loop with 'NOT' condition.

For example:
if (rs != null){rs.close();}

if (rs == null){} else{rs.close();}

Which of the above is optimised?

Thanks in advance

Sathish

[Zosden]

depends on compiler but you probably won't notice any difference in speed even if you run it a trillion times.

[Eranga]

In most of the cases, each line of a code effect to the execution completion time. If you can remove at least one line of code, it's much better.

[Zosden]

This true in only some case Eranga. Think of inlining your methods although this adds more code it also makes your program faster because of the lack of method calls. Another example would be to hardcode in a inner loop for an array search.

[Eranga]

Yes, I mentioned on my replay pal. Please read what I have written there carefully before comments on it.

And you know what, array search is much faster than calling a method. If you not believe me do a simple JUnit test and see.

[Zosden]

I'm confused by what you mean. Arrays were never mentioned in this thread nor where method calls

[Chris.Brown.SPE]

I do agree that the execution time between them is negligible, but it is just good practice to use the not statement. You don't want to have an empty block. It may have to go into the block and then see that it is empty which would take time, but compilers should optimize around that.

I would think that it would be faster to use a try/catch block on the rs.close, then it wouldnt have to do anything extra unless the file was null which i am assuming isnt going to happen very often.

[Zosden]

Most compilers will optimsize your if statment. Mostly what you want to consider is readability.

[Eranga]

Quote:

Originally Posted by Zosden

Think of inlining your methods although this adds more code it also makes your program faster because of the lack of method calls. Another example would be to hardcode in a inner loop for an array search.

If so I'm misunderstand on this.

[sukatoa]

Quote:

Please suggest me the best practice of using if loop with 'NOT' condition.

For example:
if (rs != null){rs.close();}

if (rs == null){} else{rs.close();}

Which of the above is optimised?

You may code it in favor to what you are expecting....

The first one may be faster than the second one, only if that portion always executes successfully and should be close,

What if rs has 51% chance to be null? therefore the second one is faster than the first one....

[Zosden]

I do believe but I could be wrong that with a smart compiler it would take the exact amount of time either way.

[Chris.Brown.SPE]

I agree. I would expect the java compiler to be smart enough to get those both compiled well. This would be different with an interpreted language.

[gogoc]

it is best to avoid "NOT" other then "NOT EQUALS" as it will take an extra conversion to convert the result to its not
and more over try to inscribe less executed code int the loop if u are going for multiple condition and using && in between vice-versa

[superwaxer]

Its always good programming practice to use the:

if (rs != null){rs.close();}