Please suggest me the correct approach!

[rjuyal]

Hi there,
I am having lods of tables in db.

In a file called ‘databasequery.java’ we have defined static variables to hold queries [ select/delete/insert ].



So it is like, if we want to get the query :-

Code:

Databasequery.yourtablename_select_query;

Databasequery.yourtablename_insert_statement;

Databasequery.yourtablename_update_statement;

Databasequery.yourtablename_anyother_statement;

As there are lods of tables this file is going to be very huge.



What I wanted is, there should be some mechanism to achieve this:-

Code:

DatabaseQuery.YourTableName.SELECT_QUERY;

DatabaseQuery.YourTableName.INSERT_QUERY;

also we should be able to access the "YourTableName" only via DatabaseQuery, we should not be able to write like

Code:

YourTableName.SELECT_QUERY

YourTableName.INSERT_QUERY

Please guide me..

[sanjeevtarar]

Did not understand what exactly you want.

Do you need such a method that will return you on depending the argument you are passing on it.

[rjuyal]

Thanks for the reply,

i don' need any function,

but this is just i want to change the approach i am using, there should be different java file for differenet tables. also we should no be able to access those class directly, it should be done via a common class [ databasequery or pick you name ]

[sanjeevtarar]

Ok..

Can you post your current code and how you are accessing it.

[rjuyal]

Code:

public interface DatabaseQuery {


	public static final String TABLE1_SELECT_QUERY = "SELECT * FROM content-suppressed ;)";
	public static final String TABLE2_INSERT_QUERY = "INSERT INTO content-suppressed ;) "

	public static final String TABLE2_SELECT_QUERY = "SELECT * FROM content-suppressed ;)";
	public static final String TABLE3_INSERT_QUERY = "INSERT INTO content-suppressed ;) "
;
;
;
	public static final String TABLE31_SELECT_QUERY = "SELECT * FROM content-suppressed ;)";
	public static final String TABLE31_INSERT_QUERY = "INSERT INTO content-suppressed ;) "
}

Code:

public class MyDaoImpl extends CommonDataSource implements MyDao{

public List getJobsList( MyDataBind myDataBind ) throws MyBaseDbException {
		List searchResultList = new ArrayList();
		Connection connection = null;;
		PreparedStatement preparedStatement = null;;
		ResultSet resultSet = null;;

		try {
       String queryString = DatabaseQuery.TABLE3_SELECT_QUERY; // here is want something like Databasequery.table3.SELECT_QUERY  , ,please see the 1st post :rolleyes:
       preparedStatement = connection.prepareStatement( queryString );
  -- further processing ----

}
}

[rjuyal]

i am moving to another approach, that seem to be better than previous.

Code:

public interface databasequery{
     public interface Table1{
          public interface Fields{
             all fields here
          }
          public interface Query{
             all query here
         }
    }

     public interface Table2{
          public interface Fields{
             all fields here
          }
          public interface Query{
             all query here
         }
    }

}

it is working as i expected:-

Code:

   selectQuery =  databasequery.Table1.Query.SELECT_QUERY;

do anyone is having better approach or should i stick to this one. Or please let me know if there is any flaw in this approach.

[Jesdisciple]

I think you're using classes/interfaces wrongly... A class should describe a type (or singular/static instance) of object, an object an instance of that type, and an interface a type of class. Maybe a Hashtable<String, Hashtable<String, String>> would work like you want...

Code:

//initialize
Hashtable<String, Hashtable<String, String>> databaseQuery = new Hashtable<String, Hashtable<String, String>>();

//get a table's statements
Hashtable<String, String> statements = databaseQuery.get("tableName");

//get a specific type of statement for the table
String statement = statements.get("statementType");

Or you could do:

Code:

public class DatabaseQuery extends Hashtable<String, Hashtable<String, String>> {
    //implement special get and set methods if you like
}